Add a confirmation message that the file was signed and display output filename.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

The current scripts assume the ELF file to sign contains two segments. Instead,
generate the segment with a specific file name pattern and loop through all
files, without hardcoding any number.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Add an argument to specify the tmpdir used throughout the program. This is a
useful debug feature. Do not remove the tmpdir when it's manually set. When in
debug mode, make sure the folder exists.

While at it, also removed extra blank lines in the arguments processing loop.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Input file extension is meaningless.. the input file will very soon be openned
with ELFIO, and if it's not a valid ELF valid, the program will stop anyways, so
these checks are meaningless.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

ELF32 was assumed so far, and a few hard coded constants were used. In this
patch, we avoid hardcoding and header size which are different for ELF32 and
ELF64.

Use elfio.get_class() to set the output file ELF class so that it matches the
input file ELF class.

signlk needs the section size header to compute the offset where the data needs
to be inserted, so a new file is created which contains the section size which
is different on ELF32 and ELF64.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

The script can now work with bash and POSIX shell (dash).

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Some fields in the certificate's DN might not be set (or might be empty). Newer
version of openssl (e.g. 1.1+) have a stricter DN parsing and fail to parse
empty (or too short) fields. For example, we can see such errors:

140708458570880:error:0D07A098:asn1 encoding routines:ASN1_mbstring_ncopy:string
too short:crypto/asn1/a_mbstr.c:102:minsize=1

Removing the empty (or short) fields fixes the openssl error, and XBL is still
able to authenticate the ELF file.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

'du' utility from coreutils uses TAB for delimiter, not SPACE, make the parsing
more robust.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Instead of checking if signer/signlk exists , let's unconditionally invoke the
makefile and let the makefile decide if anything need to be rebuilt. This makes
the script a bit more clear, and avoid issues if/when an old version of
signer/signlk might exist.

Also, keep the make output visible, in case something goes bad.

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

* add 'set -e' to find errors throughout script execution

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>

Yossi Mansharoff authored 8 years ago and Nico Dechesne (Stage) committed 8 years ago

Change-Id: Ia40544ef4fab49ee5402e6f17589cc173f527e9d

Yossi Mansharoff authored 8 years ago and Nico Dechesne (Stage) committed 8 years ago

Imported in git from

https://source.codeaurora.org/patches/quic/imm/PATCH_1694964_410c_signlk.tar.gz



Signed-off-by: Yossi Mansharoff <yossim@codeaurora.org>
Change-Id: Ia8823b78c4d9bbe901e6807d4ff03a29c1e496db
Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>