Skip to content
Snippets Groups Projects
  1. Oct 23, 2018
  2. Oct 15, 2018
    • Chong Zhang's avatar
      add media.codec.update service · 52fb3edb
      Chong Zhang authored
      Add a service in mediaswcodec to load updated codecs,
      and restrict it to userdebug/eng. Reuse existing
      mediaextractor_update_service since the codec update
      service is identical, this avoids adding a new one
      for now as we may not need the service anymore
      after switching to APEX.
      
      Bug: 111407413
      Bug: 117290290
      
      Change-Id: Ia75256f47433bd13ed819c70c1fb34ecd5d507b4
      52fb3edb
    • Florian Mayer's avatar
      Add heapprofd selinux config. · 4fde9ec7
      Florian Mayer authored
      This does not actually grant any permissions but just adds the
      necessary boilerplate for a new service.
      
      Bug: 117762471
      Bug: 117761873
      
      Change-Id: I7cdd2ae368616cfd54fc685c15f775604bfc80d4
      4fde9ec7
  3. Oct 13, 2018
    • Tri Vo's avatar
      Audit access to same_process_hal_file. · 81ade3dd
      Tri Vo authored
      same_process_hal_file is exempted from many Treble neverallows. We want
      to know which processes access this type to eventually constrain access
      to it.
      
      Bug: 37211678
      Test: m selinux_policy
      Change-Id: I61c0df21250eb1b1ae2d9c5fa9c801a828539813
      81ade3dd
  4. Oct 12, 2018
    • Tri Vo's avatar
      Add type for /system/bin/tcpdump. · e8b33c31
      Tri Vo authored
      We add this type with the intent to expose /system/bin/tcpdump to
      vendor on userdebug devices only.
      
      Bug: 111243627
      Test: device boots /system/bin/tcpdump correctly labeled as
      tcpdump_exec, can browse internet, turn wifi on/off
      Change-Id: Icb35e84c87120d198fbb2b44edfa5edf6021d0f0
      e8b33c31
    • Siarhei Vishniakou's avatar
      Allow system_server to read vendor_file · 3639f579
      Siarhei Vishniakou authored
      Input device configuration files .idc, .kl that are placed in /vendor
      are currently not accessible.
      Allow the read access here.
      
      Bug: 112880217
      Test: move .idc and .kl files from /system to /vendor, then observe
      logcat. With this patch, avc denials disappear.
      
      Change-Id: I72ad62b9adf415f787565adced73fd8aaff38832
      3639f579
  5. Oct 11, 2018
    • Chong Zhang's avatar
      add mediaswcodec service · bdbfff1b
      Chong Zhang authored
      Set up a new service for sw media codec services.
      
      Bug: 111407413
      
      Test: cts-tradefed run cts-dev --module CtsMediaTestCases --compatibility:module-arg CtsMediaTestCases:include-annotation:android.platform.test.annotations.RequiresDevice
      Change-Id: Ia1c6a9ef3f0c1d84b2be8756eb1853ffa0597f8e
      bdbfff1b
    • Nick Kralevich's avatar
      remove system_app proc_net_type access · 2e251461
      Nick Kralevich authored
      The auditallow added in 7a4af30b has not triggered. This is safe to
      remove.
      
      Test: device boots and no obvious problems.
      Test: No audit messages seen since May 2018 on go/sedenials
      Bug: 9496886
      Bug: 68016944
      Change-Id: I3861b462467e1fc31e67a263ad06716a4111dcb8
      2e251461
    • Tri Vo's avatar
      Constrain cgroups access. · f55c989d
      Tri Vo authored
      What changed:
      - Removed cgroup access from untrusted and priv apps.
      - Settings app writes to /dev/stune/foreground/tasks, so system_app domain
      retains access to cgroup.
      - libcutils exports API to /dev/{cpuset, stune}/*. This API seems to be used
      abundantly in native code. So added a blanket allow rule for (coredomain - apps)
      to access cgroups.
      - For now, only audit cgroup access from vendor domains. Ultimately, we want to
      either constrain vendor access to individual domains or, even better, remove
      vendor access and have platform manage cgroups exclusively.
      
      Changes from original aosp/692189 which was reverted:
      - There seem to be spurious denials from vendor-specific apps. So added
      back access from { appdomain -all_untrusted_apps -priv_app } to cgroup.
      Audit this access with intent to write explicit per-domain rules for it.
      
      Bug: 110043362
      Test: adb shell setprop ro.config.per_app_memcg true, device correctly populates
      /dev/memcg on a per app basis on a device that supports that.
      Test: aosp_sailfish, wahoo boot without cgroup denials
      This reverts commit cacea25e.
      Change-Id: I05ab404f348a864e8409d811346c8a0bf49bc47a
      f55c989d
  6. Oct 10, 2018
    • Sooraj Sasindran's avatar
      Add ians service contexts · ffaf66d4
      Sooraj Sasindran authored
      Add ians service contexts
      
      Bug: 113106744
      Test: verified from service list that ianas is
            registered
      Change-Id: Iea653416ffa45cba07a544826e0a2395d31cedca
      Merged-In: Iea653416ffa45cba07a544826e0a2395d31cedca
      ffaf66d4
    • Tri Vo's avatar
      Label /data/asan/* libs as system_lib_file. · 45d521a5
      Tri Vo authored
      This patch gives global access to asan libraries. This is not ideal since the
      labeling is not symmetric with standard locations, but this approach is easy to
      maintain.
      
      Fixes: 117555408
      Test: processes on asan builds load /data/asan/* libs correctly
      Change-Id: If54558c1808d8b16e06073c150c9f3eb358dda67
      45d521a5
    • Nick Kralevich's avatar
      Move to ioctl whitelisting for plain files / directories · ebc3a1a3
      Nick Kralevich authored
      Remove kernel attack surface associated with ioctls on plain files. In
      particular, we want to ensure that the ioctls FS_IOC_ENABLE_VERITY and
      FS_IOC_MEASURE_VERITY are not exposed outside a whitelisted set of
      entities. However, it's straight forward enough to turn on ioctl
      whitelisting for everything, so we choose to do so.
      
      Test: policy compiles and device boots
      Test: device boots with data wipe
      Test: device boots without data wipe
      Change-Id: I545ae76dddaa2193890eeb1d404db79d1ffa13c2
      ebc3a1a3
    • Nick Kralevich's avatar
      Revert "Constrain cgroups access." · cacea25e
      Nick Kralevich authored
      This reverts commit 9899568f.
      
      Reason for revert: Reports of high numbers of SELinux denials
      showing up on the SELinux dashboard.
      
      Bug: 110043362
      Change-Id: Id8fc260c47ffd269ac2f15ff7dab668c959e3ab0
      cacea25e
  7. Oct 09, 2018
    • Tri Vo's avatar
      Constrain cgroups access. · 9899568f
      Tri Vo authored
      What changed:
      - Removed cgroup access from untrusted and priv apps.
      - Settings app writes to /dev/stune/foreground/tasks, so system_app domain
      retains access to cgroup.
      - libcutils exports API to /dev/{cpuset, stune}/*. This API seems to be used
      abundantly in native code. So added a blanket allow rule for (coredomain - apps)
      to access cgroups.
      - For now, only audit cgroup access from vendor domains. Ultimately, we want to
      either constrain vendor access to individual domains or, even better, remove
      vendor access and have platform manage cgroups exclusively.
      
      Bug: 110043362
      Test: adb shell setprop ro.config.per_app_memcg true, device correctly populates
      /dev/memcg on a per app basis on a device that supports that.
      Test: aosp_sailfish, wahoo boot without cgroup denials
      Change-Id: I9e441b26792f1edb1663c660bcff422ec7a6332b
      9899568f
  8. Oct 08, 2018
    • Sudheer Shanka's avatar
      Allow zygote to search sdcardfs dirs. · 684cdb66
      Sudheer Shanka authored
      Bug: 117440207
      Bug: 111890351
      Test: manual
      Change-Id: Ie218dec3e4f0f5dbade6d1c4d28b259909664056
      684cdb66
    • Igor Murashkin's avatar
      iorapd: Add new binder service iorapd. · 72a88b19
      Igor Murashkin authored
      This daemon is very locked down. Only system_server can access it.
      
      Bug: 72170747
      Change-Id: I7b72b9191cb192be96001d84d067c28292c9688f
      72a88b19
    • Howard Ro's avatar
      Allow zygote to write to statsd and refactor · 98de322a
      Howard Ro authored
      We plan on migrating MetricsLogger to write to statsd socket. So we need to
      allow zygote, which writes to logd using MetricsLogger, to also be able
      to statsd. We also re-locate some sepolicies to write to statsd socket
      in their respective policy definitions.
      
      Bug: 110537511
      Test: no failure/violations observed
      Change-Id: I21fd352a25ed946516f9a45ac3b5e9bf97b059bc
      98de322a
    • Tri Vo's avatar
      asan: global read access to /system/asan.options · 93318192
      Tri Vo authored
      Bug: 117178352
      Test: no denials to /system/asan.options on asan walleye
      Change-Id: I6042693afb926a22a3e2be79bd2a7ba062806143
      93318192
    • Mark Salyzyn's avatar
      fs_mgr: add /mnt/scratch to possible overlayfs support directories · 1369dfca
      Mark Salyzyn authored
      A default set of options are available, but can override in a fstab
      overlay entry with upperdir=, lowerdir= to the same mount point,
      workdir=.  The default is a valid /mnt/scratch/overlay/
      or /cache/overlay/ directory, with .../<mount_point>/upper and
      .../<mount_point>/work, associated with each system partition
      <mount_point>.
      
      Test: manual
      Bug: 109821005
      Change-Id: I5662c01fad17d105665be065f6dcd7c3fdc40d95
      1369dfca
  9. Oct 04, 2018
    • Christine Franks's avatar
      Add system_api_service to color_display_service · ce3e87c0
      Christine Franks authored
      Bug: 111215474
      Test: boots
      Change-Id: Ib8cabeb64a8b4ec9f592d870bd0af611a2720cc7
      ce3e87c0
    • Martijn Coenen's avatar
      Add policy for apexd. · ac097ac4
      Martijn Coenen authored
      apexd is a new daemon for managing APEX packages installed
      on the device. It hosts a single binder service, "apexservice".
      
      Bug: 112455435
      Test: builds, binder service can be registered,
            apexes can be accessed, verified and mounted
      Change-Id: I634ad100f10b2edcd9a9c0df0d33896fa5d4ed97
      ac097ac4
  10. Oct 03, 2018
    • Nick Kralevich's avatar
      isolated_apps: no socket create · 8f08456a
      Nick Kralevich authored
      Isolated apps provide a very strict security guarantee, including the
      inability to create networking sockets like TCP / UDP sockets. Add an
      SELinux neverallow assertion to test for this and prevent regressions.
      
      Test: policy compiles.
      Change-Id: I2618abb17375707eb1048e89faa46f57d33e1df4
      8f08456a
  11. Oct 02, 2018
    • Tri Vo's avatar
      Only maintain maps between current and previous selinux versions. · 438684b3
      Tri Vo authored
      New maintenance scheme for mapping files:
      Say, V is the current SELinux platform version, then at any point in time we
      only maintain (V->V-1) mapping. (V->V-n) map is constructed from top (V->V-n+1)
      and bottom (V-n+1->V-n) without changes to previously maintained mapping files.
      
      Caveats:
      - 26.0.cil doesn't technically represent 27.0->26.0 map, but rather
      current->26.0. We'll fully migrate to the scheme with future releases.
      
      Bug: 67510052
      Test: adding new public type only requires changing the latest compat map
      Change-Id: Iab5564e887ef2c8004cb493505dd56c6220c61f8
      438684b3
    • Sooraj Sasindran's avatar
      Rename ANAS to ANS · ebf7d8ea
      Sooraj Sasindran authored
      Rename ANAS to ANS
      
      Bug: 117156243
      Test: Verified using developer options
      Change-Id: Ied208d94183a1ad493213841570ae5cd5b9c3fa8
      ebf7d8ea
  12. Oct 01, 2018
    • Tri Vo's avatar
      Address TODOs in 28.0.cil mapping. · 44383394
      Tri Vo authored
      Test: m selinux_policy
      Change-Id: I6a8ff2200c82b6ecdc1404bc7cf186f439950a30
      44383394
    • Tri Vo's avatar
      Fix incorrect 27.0 mappings. · f509e02d
      Tri Vo authored
      Map proc_qtaguid_ctrl to qtaguid_proc, not qtaguid_device.
      Map proc_slabinfo to proc in the correct place.
      
      Test: m selinux_policy
      Change-Id: I37c9dfe40bd20924215856b5d4ff7d9b3cbd0417
      f509e02d
    • Jeff Vander Stoep's avatar
      Remove access to /proc/net/{tcp,udp} · 42451772
      Jeff Vander Stoep authored
      Remove these files from proc_net_type. Domains that need access must
      have permission explicitly granted. Neverallow app access except the
      shell domain.
      
      Bug: 114475727
      Test: atest CtsLibcoreOjTestCases
      Test: netstat, lsof
      Test: adb bugreport
      Change-Id: I2304e3e98c0d637af78a361569466aa2fbe79fa0
      42451772
  13. Sep 28, 2018
    • Howard Ro's avatar
      Update sepolicies for stats hal · 578a1891
      Howard Ro authored
      Bug: 116732452
      Test: No sepolicy violations observed with this change
      (cherry picked from commit I1958182dd8ecc496625da2a2a834f71f5d43e7bb)
      
      Change-Id: Ib386767d8acfacf9fedafd9a79dd555ce233f41c
      578a1891
    • Sudheer Shanka's avatar
      Allow zygote to mount on sdcardfs dirs. · 4fc64db5
      Sudheer Shanka authored
      Bug: 111890351
      Test: manual
      Change-Id: I37d632c9877c6d6f929937d8e25098763807630c
      4fc64db5
    • Jeff Vander Stoep's avatar
      Remove untrusted app access to /proc/net · d78e07cb
      Jeff Vander Stoep authored
      This change is for testing potential app-compat issues when removing
      access to file in /proc/net. See: b/114475727#comment11.
      
      Bug: 114475727
      Test: build/boot taimen.
      Test: atest CtsLibcoreOjTestCases
      Test: FileSystemPermissionTest
      Test: ListeningPortsTest b/114772424
      Change-Id: I1db1c2b41308e47c9ec9db57ea8597a650c8906d
      (cherry picked from commit 6784f80b)
      d78e07cb
    • Chenbo Feng's avatar
      Block access to xt_qtaguid proc files · 16dbe82e
      Chenbo Feng authored
      In the next Android release, there will be devices that have no
      xt_qtaguid module at all and framework and netd will decide which code
      path it takes for trafficStats depending on the device setup. So all
      apps and services should not depend on this device specific
      implementation anymore and use public API for the data they need.
      
      Bug: 114475331
      Bug: 79938294
      Test: QtaguidPermissionTest
      
      Change-Id: I0d37b2df23782eefa2e8977c6cdbf9210db3e0d2
      16dbe82e
  14. Sep 27, 2018
    • Wei Wang's avatar
      Add atrace HAL 1.0 sepolicy · bc71a610
      Wei Wang authored
      Bug: 111098596
      Test: atrace/systrace
      
      (cherry picked from commit 9ed5cf6e)
      
      Change-Id: I97772ff21754d03a0aea0d53b39e8da5312a17c0
      bc71a610
    • Howard Ro's avatar
      Update sepolicies for stats hal · 9f9af0db
      Howard Ro authored
      Bug: 116732452
      Test: no sepolicy violations observed with this change
      Change-Id: I1958182dd8ecc496625da2a2a834f71f5d43e7bb
      9f9af0db
    • Nick Kralevich's avatar
      Introduce system_file_type · 5e37271d
      Nick Kralevich authored
      system_file_type is a new attribute used to identify files which exist
      on the /system partition. It's useful for allow rules in init, which are
      based off of a blacklist of writable files. Additionally, it's useful
      for constructing neverallow rules to prevent regressions.
      
      Additionally, add commented out tests which enforce that all files on
      the /system partition have the system_file_type attribute. These tests
      will be uncommented in a future change after all the device-specific
      policies are cleaned up.
      
      Test: Device boots and no obvious problems.
      Change-Id: Id9bae6625f042594c8eba74ca712abb09702c1e5
      5e37271d
    • Nick Kralevich's avatar
      Label /system/usr/share/zoneinfo differently · ff1c765f
      Nick Kralevich authored
      /system/usr/share/zoneinfo is currently labeled zoneinfo_data_file,
      a label shared with /data/misc/zoneinfo. However, each of these
      directory locations has different security characteristics. In
      particular, the files in /system/usr/share/zoneinfo must never be
      writable, whereas /data/misc/zoneinfo may be written to by system_server.
      Reusing the same label hides these different security characteristics.
      
      Create a separate label for /system/usr/share/zoneinfo.
      
      Test: Device boots and no obvious problems.
      Change-Id: I8cf16ff038b06b38f77388e546d9b7a6865f7879
      ff1c765f
  15. Sep 26, 2018
    • Hector Dearman's avatar
      Make system_server atrace category work with traced_probes · 63d07d75
      Hector Dearman authored
      Historically most uses of atrace happen via the shell domain.
      
      There are two exceptions:
      - boot tracing
      - traced_probes
      
      We need to get feature parity, so atrace has the same behavior
      when is invoked either via shell or from its own domain (e.g.
      via traced_probes that has an auto_trans rule into atrace on exec).
      Atrace works by setting system properties to enable tracing from userspace
      then poking all the binder services to read the system properties (see [1]) so
      enabling the system_server category requires the ability to call binder
      methods on the system_server.
      
      For more use cases see b/113127224
      
      [1]: https://android.googlesource.com/platform/frameworks/native/+/9ead54bed65d486fe435793cbe98ed8b4786f7be/cmds/atrace/atrace.cpp#545
      
      Bug: 113127224
      Test: Add an atrace category to the Perfetto config and confirm the data
      shows up.
      
      Cherry-picked from aosp/747608
      
      Change-Id: Id077eff960ffb1cdd7b0ce84b21ac9ef70444a4a
      Merged-In: Id077eff960ffb1cdd7b0ce84b21ac9ef70444a4a
      63d07d75
    • Wei Wang's avatar
      Add atrace HAL 1.0 sepolicy · 9ed5cf6e
      Wei Wang authored
      Bug: 111098596
      Test: atrace/systrace
      Change-Id: I06ca76750d640c98849c475c8a237d62c8e582b9
      9ed5cf6e
  16. Sep 24, 2018
    • Tri Vo's avatar
      Label /system/bin/linker* symlinks as system_file. · 6cd9bd07
      Tri Vo authored
      Fixes:
      avc: denied { read } for comm="init" name="linker_asan64" dev="sda22" ino=1833
      scontext=u:r:init:s0 tcontext=u:object_r:system_linker_exec:s0 tclass=lnk_file
      permissive=0
      
      Bug: 116486312
      Test: adb unroot && adb shell ls -l /system/bin/linker_asan
      Change-Id: I754daaf3576e83d516cc9189b8be04dcc41bbc5c
      6cd9bd07
    • Fan Xu's avatar
      Update SELinux Policy for bufferhubd · 26fa914c
      Fan Xu authored
      Create a new service type buffer_hub_binder_service for
      BufferHubBinderService and allow bufferhubd to publish the service.
      
      Add the service to 26.0, 27.0 and 28.0 compat ignore files since the
      service is not available in past versions.
      
      Fixes: 116022258
      Test: build passed
      
      Change-Id: I5a21f00329ed474433d96c8d1ce32377f20cada3
      26fa914c
    • Tej Singh's avatar
      Sepolicy for migrating storaged to statsd · 44d47c03
      Tej Singh authored
      This adds /proc/uid_io/stats to the files that system server is able to
      read.
      
      Test: Manual test on master produces no selinux violations.
      Change-Id: I2c7afec149f893b000094739d91531dec559de6f
      44d47c03
Loading