Skip to content
Snippets Groups Projects
  1. Aug 21, 2018
    • Tri Vo's avatar
      Rename untrusted_app_visible_*' to include 'violators'. · 7f8b6cc6
      Tri Vo authored
      Bug: 110887137
      Test: Flash new system policy onto a device with vendor policy that uses
      untrusted_app_visible_* attributes, and check that old and new attributes
      are applied to exactly same types.
      Change-Id: Ibee0ec645878fcc8c93cd0fbd169a8d45129d79e
      Merged-In: Ibee0ec645878fcc8c93cd0fbd169a8d45129d79e
      (cherry picked from commit 7abca51d)
      7f8b6cc6
    • Benjamin Gordon's avatar
      sepolicy: Fix references to self:capability · 7ed266c6
      Benjamin Gordon authored
      commit 9b2e0cbe added a new
      self:global_capability_class_set macro that covers both self:capability
      and self:cap_userns.  Apply the new macro to various self:capability
      references that have cropped up since then.
      
      Bug: 112307595
      Test: policy diff shows new rules are all cap_userns
      Change-Id: I3eb38ef07532a8e693fd549dfdbc4a6df5329609
      7ed266c6
    • Yifan Hong's avatar
      3784e7fc
  2. Aug 20, 2018
  3. Aug 17, 2018
  4. Aug 15, 2018
  5. Aug 14, 2018
    • Steven Moreland's avatar
      Remove old incidentd socket allow. · fa3c138a
      Steven Moreland authored
      Forgotten cleanup item.
      
      Bug: 35870313
      Test: making sepolicy (neverallows resolved at compile time)
      Change-Id: If9a583c4508db63356869502ec374727afa84b0b
      fa3c138a
    • Nick Kralevich's avatar
      Fix m4 warnings · 85508496
      Nick Kralevich authored
      Quotes and backticks are sensitive characters and should never show up
      in a comment. Fix comment to avoid the use of a single quote. Also fixes
      a bug where certain rules were not getting included in the compiled
      policy.
      
      Fixes the following build warnings:
      
      [  3% 3564/114975] build out/target/product/taimen/obj/ETC/sepolicy_neverallows_intermediates/plat_pub_policy.conf
      m4:system/sepolicy/public/te_macros:404: Warning: excess arguments to builtin `define' ignored
      [  3% 3578/114975] build out/target/product/taimen/obj/ETC/plat_sepolicy.cil_intermediates/plat_policy.conf
      m4:system/sepolicy/public/te_macros:404: Warning: excess arguments to builtin `define' ignored
      [  3% 3579/114975] build out/target/product/taimen/obj/ETC/vendor_sepolicy.cil_intermediates/vendor_policy.conf
      m4:system/sepolicy/public/te_macros:404: Warning: excess arguments to builtin `define' ignored
      [  3% 3607/114975] build out/target/product/taimen/obj/ETC/sepolicy_neverallows_intermediates/policy.conf
      m4:system/sepolicy/public/te_macros:404: Warning: excess arguments to builtin `define' ignored
      [  3% 3677/114975] build out/target/product/taimen/obj/ETC/built_plat_sepolicy_intermediates/base_plat_policy.conf
      m4:system/sepolicy/public/te_macros:404: Warning: excess arguments to builtin `define' ignored
      
      Test: policy compiles and no warnings.
      Change-Id: Ie32d8b536955b40888b79e3a93851d2ae297f8ee
      85508496
    • Jerry Zhang's avatar
      Add sepolicy for fastbootd · 0fd3ed3b
      Jerry Zhang authored
      Also allow adb and fastboot to talk to recovery
      through recovery_socket. This enables changing
      between modes with usb commands.
      
      Test: No selinux denials
      Bug: 78793464
      Change-Id: I1f97659736429fe961319c642f458c80f199ffb4
      0fd3ed3b
    • Mark Salyzyn's avatar
      fs_mgr: use ro.persistent_properties.ready · 7ab1450d
      Mark Salyzyn authored
      Replace more complicated logic that determines that persistent
      properties are now valid with a simple check of
      ro.persistent_properties.ready.
      
      Test: manual
      Bug: 109821005
      Change-Id: I8c63beb294377ea9ce6eb6336b83f529deedd830
      7ab1450d
    • Tri Vo's avatar
      Sepolicy for system suspend HAL. · dac2a4a3
      Tri Vo authored
      Bug: 78888165
      Test: device can boot with HAL running.
      Change-Id: I3bf7c8203e038b892176c97ec006152a2904c7be
      dac2a4a3
    • Tri Vo's avatar
      Merge "neverallow fwk access to /vendor" · fdbd8519
      Tri Vo authored
      fdbd8519
  6. Aug 13, 2018
    • Yifan Hong's avatar
      Merge "vold uses health filesystem HAL" · 29940d7a
      Yifan Hong authored
      29940d7a
    • Treehugger Robot's avatar
    • Treehugger Robot's avatar
      b90595cb
    • Treehugger Robot's avatar
      ad3eb4e2
    • Nick Kralevich's avatar
      Revert "Change priv-apps /home/home labels to privapp_data_file" · cdc6649a
      Nick Kralevich authored
      There is a problem with on-disk labeling of files created by secondary
      dex background compilation which is causing unexpected denials to show
      up. Restore the old labeling until we are able to fix the underlying
      problem.
      
      Steps to reproduce:
        1) boot android device.
        2) adb root
        3) Run cmd package compile -r bg-dexopt --secondary-dex com.google.android.gms
        4) Examine the files in /data/user_de/0/com.google.android.gms
      Expected:
        All files have the label privapp_data_file
      Actual:
        The files in /data/user_de/0/com.google.android.gms/app_chimera/m
        are labeled "app_data_file", not "privapp_data_file".
      
      This reverts commit 4df57822.
      
      Bug: 112357170
      Test: policy compiles
      Change-Id: I38ba75c92c9c46e6a1fdbc02e3dc80c63adccaa8
      cdc6649a
    • Nick Kralevich's avatar
      Revert "auditallow app_data_file execute" · c47e149a
      Nick Kralevich authored
      There is a problem with on-disk labeling of files created by secondary
      dex background compilation which is causing unexpected denials to show
      up. Drop the auditallow rule to avoid logspam.
      
      Steps to reproduce:
        1) boot android device.
        2) adb root
        3) Run cmd package compile -r bg-dexopt --secondary-dex com.google.android.gms
        4) Examine the files in /data/user_de/0/com.google.android.gms
      Expected:
        All files have the label privapp_data_file
      Actual:
        The files in /data/user_de/0/com.google.android.gms/app_chimera/m
        are labeled "app_data_file", not "privapp_data_file".
      
      Addresses the following audit logspam:
        type=1400 audit(0.0:117): avc: granted { execute } for comm=4173796E635461736B202331 path="/data/user_de/0/com.google.android.gms/app_chimera/m/00000002/oat/arm/DynamiteLoader.odex" dev="dm-0" ino=5775 scontext=u:r:untrusted_app:s0:c111,c256,c512,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file app=com.android.chrome
      
      Additionally, this removes auditallow statements for older untrusted
      apps. Lots of big apps are executing files from their home directory.
      Additional restrictions in this area will need to be tied to API
      versions.
      
      Addresses the following audit logspam:
        type=1400 audit(0.0:619): avc: granted { execute } for comm="na:notification" path="/data/data/com.facebook.katana/lib-xzs/libbreakpad.so" dev="dm-3" ino=28333 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file app=com.facebook.katana
        type=1400 audit(0.0:129): avc: granted { execute } for comm="ticlock" path="/data/data/is.shortcut/files/ticlock/ticlock" dev="dm-3" ino=58614 scontext=u:r:untrusted_app_27:s0:c512,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file app=is.shortcut
        type=1400 audit(0.0:1239): avc: granted { execute } for comm="Analytics-Norma" path="/data/data/com.facebook.orca/lib-xzs/libchipsetmerged.so" dev="dm-3" ino=50243 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file app=com.facebook.orca
        type=1400 audit(0.0:58): avc: granted { execute_no_trans } for comm="sh" path="/data/data/is.shortcut/files/ticlock/ticlock" dev="dm-3" ino=58614 scontext=u:r:untrusted_app_27:s0:c512,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file app=is.shortcut
        type=1400 audit(0.0:1948): avc: granted { execute_no_trans } for comm="sh" path="/data/data/com.mxdata.tube.Market/files/osmcore" dev="sda13" ino=2752651 scontext=u:r:untrusted_app_25:s0:c512,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file app=com.mxdata.tube.Market
        type=1400 audit(0.0:2875): avc: granted { execute_no_trans } for comm="ThreadPoolManag" path="/data/data/com.amazon.kindle/files/hardwareTest" dev="sda13" ino=1935346 scontext=u:r:untrusted_app_27:s0:c512,c768 tcontext=u:object_r:app_data_file:s0:c512,c768 tclass=file app=com.amazon.kindle
      
      This reverts commit 4738b93d.
      
      Bug: 112357170
      Test: policy compiles
      c47e149a
    • Nick Kralevich's avatar
      suppress some su related denials · 690be8e8
      Nick Kralevich authored
      The su domain is always permissive. Operations which occur in this
      domain should never be logged.
      
      Addresses the following denials:
      
        type=1400 audit(0.0:864): avc: denied { module_load } for comm="insmod" path="/data/lcd.ko.gz" dev="sda21" ino=143150 scontext=u:r:su:s0 tcontext=u:object_r:system_data_file:s0 tclass=system permissive=1
        type=1400 audit(0.0:858): avc: denied { module_load } for comm="insmod" path="/vendor/lib/modules/lcd.ko" dev="sda9" ino=880 scontext=u:r:su:s0 tcontext=u:object_r:vendor_file:s0 tclass=system permissive=1
        type=1400 audit(0.0:37495): avc: denied { prog_run } for comm="ip6tables" scontext=u:r:su:s0 tcontext=u:r:bpfloader:s0 tclass=bpf permissive=1
        type=1400 audit(0.0:31): avc: denied { map_create } for comm="netd_unit_test" scontext=u:r:su:s0 tcontext=u:r:su:s0 tclass=bpf permissive=1
        type=1400 audit(0.0:32): avc: denied { map_read map_write } for comm="netd_unit_test" scontext=u:r:su:s0 tcontext=u:r:su:s0 tclass=bpf permissive=1
      
      Test: policy compiles
      Change-Id: I490c8566577fde64bdd0201bb8f9112ff6ac96d4
      690be8e8
    • Nick Kralevich's avatar
      more mmaps · bedfb22a
      Nick Kralevich authored
      Linux kernel 4.14+ SELinux starts explicit map
      permission check for file mmap operations. For backards
      compat, add mmap in more places where we explicitly
      list out individual file permissions.
      
      Test: policy compiles
      Change-Id: Idc4ca53769f2e7aa12ed93ab27191ed92da37a3e
      bedfb22a
  7. Aug 11, 2018
    • Tri Vo's avatar
      neverallow fwk access to /vendor · 44b7d5b8
      Tri Vo authored
      This rule prevents adding further fwk->vendor access.
      Left a TODO to clean up already existing access.
      
      Bug: 37168747
      Test: build sailfish, walleye policies
      Change-Id: I5e61d0b94b81df228628dba5746e084f291a7904
      44b7d5b8
  8. Aug 10, 2018
  9. Aug 09, 2018
  10. Aug 08, 2018
Loading