Skip to content
Snippets Groups Projects
  1. Nov 01, 2018
  2. Oct 10, 2018
  3. Sep 04, 2018
    • Mark Salyzyn's avatar
      llkd: Add stack symbol checking · 275ea12d
      Mark Salyzyn authored
      llkd needs the ptrace capabilities and dac override to monitor for
      live lock conditions on the stack dumps.
      
      Test: compile
      Bug: 33808187
      Change-Id: Ibc1e4cc10395fa9685c4ef0ca214daf212a5e126
      275ea12d
  4. Aug 10, 2018
  5. Jun 26, 2018
    • Samuel Ha's avatar
      Revert "Revert "Reduce the number of processes that can start adbd"" · 22f98197
      Samuel Ha authored
      This reverts commit b5dc6137.
      
      Reason for revert: Reverted incorrect change
      
      Change-Id: Ieafa3338e28ffeed40bcceb73486cffbfbd08b9d
      22f98197
    • Samuel Ha's avatar
      Revert "Reduce the number of processes that can start adbd" · b5dc6137
      Samuel Ha authored
      This reverts commit faebeaca.
      
      Reason for revert: broke the build
      
      Change-Id: I3d61ce011ad42c6ff0e9f122de3daa37e846407a
      b5dc6137
    • Luis Hector Chavez's avatar
      Reduce the number of processes that can start adbd · faebeaca
      Luis Hector Chavez authored
      This change makes it such that only init can start adbd directly. It
      also introduces new rules for ctl.{start,stop,restart} properties such
      that only usbd and recovery (and su, since it's permissive) can directly
      ask init to start adbd.
      
      Bug: 64720460
      Test: adbd still runs
      Test: /data/nativetest64/adbd_test/adbd_test
      Test: python system/core/adb/test_adb.py
      Test: "USB debugging" in System Settings still start/stop adbd
      Test: Recovery menu still make the device show as "recovery" in adb
            devices
      Test: "Apply update from ADB" in recovery menu still works
      Change-Id: Iafcda8aa44e85129afcc958036b472d856fa1192
      faebeaca
  6. Jun 25, 2018
    • Eino-Ville Talvala's avatar
      Make system property audio.camerasound.force a vendor-writable property, · 3ac71f8d
      Eino-Ville Talvala authored
      This property is read by the audio service in system server to toggle
      camera shutter sound enforcement on a device-specific basis.
      
      Test: Camera shutter sound enforcement works when audio.camerasound.force is set
      Bug: 110126976
      Change-Id: I2720d3c699c4712d1a328f59dde0b16bbf1016f3
      3ac71f8d
    • Neil Fuller's avatar
      Add label for time (zone) system properties · b794ad0f
      Neil Fuller authored
      This adds a label for system properties that will affect system-wide
      time / time detection logic.
      
      The first example will be something like:
      persist.time.detection_impl_version
      
      Bug: 78217059
      Test: build
      Change-Id: I46044f1e28170760001da9acf2496a1e3037e48a
      b794ad0f
  7. Jun 21, 2018
  8. Jun 01, 2018
    • Tri Vo's avatar
      Revert "Remove neverallow coredomain to set vendor prop." · ba79e154
      Tri Vo authored
      Bug: 80466516
      Bug: 78598545
      This reverts commit 6f6fbebc.
      
      Change-Id: I3c0f374b846241571b5db6f061503f0ea2d6396a
      ba79e154
    • Jiyong Park's avatar
      add extended_core_property_type · d8ae0071
      Jiyong Park authored
      The attribute is used to capture system properties added from outside of
      AOSP (e.g. by OEM), but are not device-specific and thus are used only
      inside the system partition.
      
      Access to the the system properties from outside of the system partition
      is prevented by the neverallow rule.
      
      Bug: 80382020
      Bug: 78598545
      Test: m -j selinux_policy
      Merged-In: I22c083dc195dab84c9c21a79fbe3ad823a3bbb46
      Change-Id: I22c083dc195dab84c9c21a79fbe3ad823a3bbb46
      (cherry picked from commit c0f8f2f8)
      d8ae0071
    • Tom Cherry's avatar
      neverallow coredomain from writing vendor properties · 5897e23e
      Tom Cherry authored
      System properties can be abused to get around Treble requirements of
      having a clean system/vendor split.  This CL seeks to prevent that by
      neverallowing coredomain from writing vendor properties.
      
      Bug: 78598545
      Test: build 2017 Pixels
      Test: build aosp_arm64
      Change-Id: I5e06894150ba121624d753228e550ba9b81f7677
      (cherry picked from commit cdb1624c)
      5897e23e
  9. May 31, 2018
    • Tri Vo's avatar
      Remove neverallow coredomain to set vendor prop. · 6f6fbebc
      Tri Vo authored
      We are not forbidding system_writes_vendor_properties_violators in P,
      i.e. this neverallow rule is not strictly enforced.
      
      Bug: 80466516
      Bug: 78598545
      Test: build policy
      Change-Id: Iaf0ebbd2b27adf8c48082caa874e53f32bf999fc
      6f6fbebc
  10. May 30, 2018
    • Jiyong Park's avatar
      add extended_core_property_type · c0f8f2f8
      Jiyong Park authored
      The attribute is used to capture system properties added from outside of
      AOSP (e.g. by OEM), but are not device-specific and thus are used only
      inside the system partition.
      
      Access to the the system properties from outside of the system partition
      is prevented by the neverallow rule.
      
      Bug: 80382020
      Bug: 78598545
      Test: m -j selinux_policy
      Change-Id: I22c083dc195dab84c9c21a79fbe3ad823a3bbb46
      c0f8f2f8
  11. May 23, 2018
    • Jeff Vander Stoep's avatar
      Use non-expanded types in prop neverallows · 7745770b
      Jeff Vander Stoep authored
      Using hal_foo attributes in neverallow rules does not work because
      they are auto-expanded to types. Use hal_foo_server types instead.
      
      Fixes the following error:
      unit.framework.AssertionFailedError: The following errors were
      encountered when validating the SELinuxneverallow rule: neverallow
      { domain -coredomain -bluetooth -hal_bluetooth } { bluetooth_prop }:
      property_service set; Warning! Type or attribute hal_bluetooth used
      in neverallow undefined in policy being checked.
      
      Test: CtsSecurityHostTestCases
      Bug: 80153368
      Change-Id: I2baf9f66d2ff110a4f181423790a1160a6e138da
      7745770b
  12. May 22, 2018
    • Tom Cherry's avatar
      Finer grained permissions for ctl. properties · 7b8be35d
      Tom Cherry authored
      Currently, permissions for ctl. property apply to each action verb, so
      if a domain has permissions for controlling service 'foo', then it can
      start, stop, and restart foo.
      
      This change implements finer grainer permissions such that permission
      can be given to strictly start a given service, but not stop or
      restart it.  This new permission scheme is mandatory for the new
      control functions, sigstop_on, sigstop_off, interface_start,
      interface_stop, interface_restart.
      
      Bug: 78511553
      Test: see appropriate successes and failures based on permissions
      Merged-In: Ibe0cc0d6028fb0ed7d6bcba626721e0d84cc20fa
      Change-Id: Ibe0cc0d6028fb0ed7d6bcba626721e0d84cc20fa
      (cherry picked from commit 2208f96e)
      7b8be35d
    • Tom Cherry's avatar
      Finer grained permissions for ctl. properties · 2208f96e
      Tom Cherry authored
      Currently, permissions for ctl. property apply to each action verb, so
      if a domain has permissions for controlling service 'foo', then it can
      start, stop, and restart foo.
      
      This change implements finer grainer permissions such that permission
      can be given to strictly start a given service, but not stop or
      restart it.  This new permission scheme is mandatory for the new
      control functions, sigstop_on, sigstop_off, interface_start,
      interface_stop, interface_restart.
      
      Bug: 78511553
      Test: see appropriate successes and failures based on permissions
      
      Change-Id: Ibe0cc0d6028fb0ed7d6bcba626721e0d84cc20fa
      2208f96e
  13. May 18, 2018
    • Tom Cherry's avatar
      neverallow coredomain from writing vendor properties · cdb1624c
      Tom Cherry authored
      System properties can be abused to get around Treble requirements of
      having a clean system/vendor split.  This CL seeks to prevent that by
      neverallowing coredomain from writing vendor properties.
      
      Bug: 78598545
      Test: build 2017/2018 Pixels
      Test: build aosp_arm64
      Change-Id: I5e06894150ba121624d753228e550ba9b81f7677
      cdb1624c
  14. May 09, 2018
    • Mark Salyzyn's avatar
      FrameworksServicesTests: allow access to test.sys.boot.reason property · 1b748766
      Mark Salyzyn authored
      com.android.server.power.PowerManagerServiceTest#testGetLastShutdownReasonInternal due to "RuntimeException: failed to set system property"
      
      W/roidJUnitRunner: type=1400 audit(0.0:6): avc: denied { write } for name="property_service" dev="tmpfs" ino=13178 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:property_socket:s0 tclass=sock_file permissive=0
      W/libc    : Unable to set property "test.sys.boot.reason" to "shutdown,thermal": connection failed; errno=13 (Permission denied)
      
      Had to use precise property definition as com.android.phone accesses
      test properties as well.
      
      Test: compile
      Bug: 78245377
      Change-Id: I2cc810846f8615f2a2fae8e0d4f41de585b7abd7
      1b748766
  15. May 04, 2018
  16. May 03, 2018
    • Mark Salyzyn's avatar
      FrameworksServicesTests: allow access to test.sys.boot.reason property · 0ab13a8d
      Mark Salyzyn authored
      com.android.server.power.PowerManagerServiceTest#testGetLastShutdownReasonInternal due to "RuntimeException: failed to set system property"
      
      W/roidJUnitRunner: type=1400 audit(0.0:6): avc: denied { write } for name="property_service" dev="tmpfs" ino=13178 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:property_socket:s0 tclass=sock_file permissive=0
      W/libc    : Unable to set property "test.sys.boot.reason" to "shutdown,thermal": connection failed; errno=13 (Permission denied)
      
      Test: compile
      Bug: 78245377
      Change-Id: Id21436d281bab27823969a9f7e92318d70b5a2d6
      0ab13a8d
  17. Apr 26, 2018
  18. Apr 23, 2018
    • Lalit Maganti's avatar
      sepolicy: allow shell to read/write traced prop · 00c8e3d9
      Lalit Maganti authored
      This is to fix the CTS failures given by the bugs below where devices
      where traced is not enabled by default causes test failures.
      
      (cherry picked from commit 673b4db7)
      
      Bug: 78215159
      Bug: 78347829
      Change-Id: Ib0f6a1cdb770528dbbeb857368534ff5040e464e
      00c8e3d9
    • Lalit Maganti's avatar
      sepolicy: allow shell to read/write traced prop · 673b4db7
      Lalit Maganti authored
      This is to fix the CTS failures given by the bugs below where devices
      where traced is not enabled by default causes test failures.
      
      Bug: 78215159
      Bug: 78347829
      Change-Id: Ib0f6a1cdb770528dbbeb857368534ff5040e464e
      673b4db7
  19. Apr 19, 2018
  20. Apr 18, 2018
  21. Apr 13, 2018
    • Jaekyun Seok's avatar
      Whitelist vendor-init-settable bluetooth_prop and wifi_prop · a11b16c9
      Jaekyun Seok authored
      Values of the following properties are set by SoC vendors on some
      devices including Pixels.
      - persist.bluetooth.a2dp_offload.cap
      - persist.bluetooth.a2dp_offload.enable
      - persist.vendor.bluetooth.a2dp_offload.enable
      - ro.bt.bdaddr_path
      - wlan.driver.status
      
      So they should be whitelisted for compatibility.
      
      Bug: 77633703
      Test: succeeded building and tested with Pixels
      Change-Id: Ib2b81bcc1fd70ddd571dc7fb2b923b576d62b7d5
      Merged-In: Ib2b81bcc1fd70ddd571dc7fb2b923b576d62b7d5
      (cherry picked from commit 224921d1)
      a11b16c9
    • Jaekyun Seok's avatar
      Whitelist vendor-init-settable bluetooth_prop and wifi_prop · 224921d1
      Jaekyun Seok authored
      Values of the following properties are set by SoC vendors on some
      devices including Pixels.
      - persist.bluetooth.a2dp_offload.cap
      - persist.bluetooth.a2dp_offload.enable
      - persist.vendor.bluetooth.a2dp_offload.enable
      - ro.bt.bdaddr_path
      - wlan.driver.status
      
      So they should be whitelisted for compatibility.
      
      Bug: 77633703
      Test: succeeded building and tested with Pixels
      Change-Id: Ib2b81bcc1fd70ddd571dc7fb2b923b576d62b7d5
      224921d1
  22. Apr 09, 2018
    • Max Bires's avatar
      Adding labeling for vendor security patch prop · 5cac1aa9
      Max Bires authored
      This will allow adb shell getprop ro.vendor.build.security_patch to
      properly return the correct build property, whereas previously it was
      offlimits due to lack of label.
      
      Test: adb shell getprop ro.vendor.build.security_patch successfully
      returns whatever VENDOR_SECURITY_PATCH is defined to be in the Android
      .mk files
      
      Change-Id: Ie8427738125fc7f909ad8d51e4b76558f5544d49
      5cac1aa9
  23. Mar 28, 2018
    • Jaekyun Seok's avatar
      Allow vendor-init-settable to persist.radio.multisim.config · 7d3bd8db
      Jaekyun Seok authored
      A default value of persist.radio.multisim.config can be set by SoC
      vendors, and so vendor-init-settable should be allowed to it.
      
      Bug: 73871799
      Test: succeeded building and tested with taimen
      Change-Id: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4
      Merged-In: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4
      (cherry picked from commit ac8c6e3d)
      7d3bd8db
  24. Mar 27, 2018
    • Jaekyun Seok's avatar
      Allow vendor-init-settable to persist.radio.multisim.config · ac8c6e3d
      Jaekyun Seok authored
      A default value of persist.radio.multisim.config can be set by SoC
      vendors, and so vendor-init-settable should be allowed to it.
      
      Bug: 73871799
      Test: succeeded building and tested with taimen
      Change-Id: Ie62b91e7e3d7e05425b742838417f1cab7b3fed4
      ac8c6e3d
  25. Mar 26, 2018
    • Primiano Tucci's avatar
      Revert "Allow system server to set persist.traced.enable" · 4f673cf4
      Primiano Tucci authored
      This reverts commit 6f2040f8.
      
      Reason for revert: not needed anymore after ag/3773705
      This was meant to allow system_server toggling the property on/off.
      Later we realized that we needed a separate property for that 
      (see discussion in b/76077784) and system server happens to
      have already permissions to write to sys.* properties even without
      this CL.
      Reverting because at this point this creates just unnecessary clutter.
      
      Change-Id: Ia73d000aad3c4288a5652047dfe10896e231b0b1
      Test: perfetto_integrationtests
      Bug: 76077784
      4f673cf4
  26. Mar 19, 2018
    • Hector Dearman's avatar
      Allow system server to set persist.traced.enable · 6f2040f8
      Hector Dearman authored
      To enable/disable the traced and traced_probes deamons remotely we would
      like system server to be able to set persist.traced.enable.
      See also ag/3736001.
      
      Denial:
      selinux: avc: denied { set } for
      property=persist.traced.enable
      pid=1606 uid=1000 gid=1000
      scontext=u:r:system_server:s0
      tcontext=u:object_r:default_prop:s0 tclass=property_service
      permissive=0\x0a
      
      Run:
      $ adb shell 'ps -A | grep traced'
      Should see traced.
      $ adb shell 'settings put global sys_traced 0'
      $ adb shell 'ps -A | grep traced'
      Should no longer see traced.
      
      Test: See above.
      Change-Id: I245b7df3853cabeb0e75db41fb4facaa178ab8f1
      6f2040f8
  27. Mar 18, 2018
  28. Mar 16, 2018
  29. Mar 12, 2018
Loading