Skip to content
Snippets Groups Projects
  1. Oct 25, 2018
  2. Oct 24, 2018
  3. Oct 23, 2018
    • Jeff Sharkey's avatar
      910de2a4
    • Sudheer Shanka's avatar
      Merge "Track vrcore_app SELinux denial" · 11da725c
      Sudheer Shanka authored
      11da725c
    • Jeff Sharkey's avatar
      sepolicy should be fully developed in AOSP. · ee64b0bc
      Jeff Sharkey authored
      Bug: 113136846
      Test: manual
      Change-Id: I5c515ca4eafb39c4c3d04b3e736471ae38d38545
      ee64b0bc
    • Nick Kralevich's avatar
      update_engine_common: expand default allowed ioctl list · 7b5e82a8
      Nick Kralevich authored
      update_engine does a lot to keep partitions secure and tidy. Allow the
      ioctls necessary to allow that to happen.
      
      Addresses the following denials:
      
      update_engine: type=1400 audit(0.0:6): avc: denied { ioctl } for path="/dev/block/sda20" dev="tmpfs" ino=13850 ioctlcmd=1277 scontext=u:r:update_engine:s0 tcontext=u:object_r:boot_block_device:s0 tclass=blk_file permissive=0
      update_engine: type=1400 audit(0.0:8): avc: denied { ioctl } for path="/dev/block/sda20" dev="tmpfs" ino=13850 ioctlcmd=127c scontext=u:r:update_engine:s0 tcontext=u:object_r:boot_block_device:s0 tclass=blk_file permissive=0
      update_engine: type=1400 audit(0.0:9): avc: denied { ioctl } for path="/dev/block/sda20" dev="tmpfs" ino=13850 ioctlcmd=127f scontext=u:r:update_engine:s0 tcontext=u:object_r:boot_block_device:s0 tclass=blk_file permissive=0
      update_engine: type=1400 audit(0.0:13): avc: denied { ioctl } for path="/dev/block/sda18" dev="tmpfs" ino=12601 ioctlcmd=127d scontext=u:r:update_engine:s0 tcontext=u:object_r:custom_ab_block_device:s0 tclass=blk_file permissive=0
      
      Bug: 118319505
      Test: policy compiles.
      Change-Id: I424f2a13ced2324b4c0c35b0f510b9aea748d5aa
      7b5e82a8
    • Sudheer Shanka's avatar
      Track vrcore_app SELinux denial · 95767cce
      Sudheer Shanka authored
      Bug: 118185801
      Test: bug no. appears in the denial logs
      Change-Id: Ib1d1bbbdf25e0e63ac8a7dec98aca08cafc3f870
      95767cce
    • Nick Kralevich's avatar
      Expand BLKROGET and BLKROSET to all block devices. · e844681c
      Nick Kralevich authored
      Update engine is responsible for updating various partitions, which
      includes enabling or disabling the read-only bit on the underlying block
      device.
      
      Rather than try to list out each block device separately, generalize the
      ioctl rules to apply to all block device nodes. If the ioctl permission
      is granted via a normal allow rule, then the allowxperm statement will
      allow BLKROGET and BLKROSET by default on those block devices.
      
      Test: policy compiles
      Bug: 118150702
      Change-Id: I7bca52e0f442df7320748f6d6371e5016aa6dd0b
      e844681c
    • Anton Hansson's avatar
      Add sepolicy for preloads_copy script · edd13bc3
      Anton Hansson authored
      Copied from device/google/crosshatch-sepolicy.
      
      Test: diff files in system/etc/selinux before and after for aosp_marlin
      Change-Id: I518c43af9c217483bdab02424e4aef0270aad366
      edd13bc3
    • Nick Kralevich's avatar
      vold.te: allow BLKSECDISCARD · 787fc8d0
      Nick Kralevich authored
      vold needs to securely delete content from various block devices. Allow
      it.
      
      Addresses the following denials:
      
      type=1400 audit(0.0:66): avc: denied { ioctl } for comm="secdiscard" path="/dev/block/dm-3" dev="tmpfs" ino=17945 ioctlcmd=0x127d scontext=u:r:vold:s0 tcontext=u:object_r:dm_device:s0 tclass=blk_file permissive=0
      type=1400 audit(0.0:43): avc: denied { ioctl } for comm="secdiscard" path="/dev/block/sda45" dev="tmpfs" ino=17485 ioctlcmd=127d scontext=u:r:vold:s0 tcontext=u:object_r:userdata_block_device:s0 tclass=blk_file permissive=0
      
      Test: policy compiles.
      Change-Id: Ie7b4b8ac4698d9002a4e8d142d4e463f8d42899a
      787fc8d0
    • ji, zhenlong z's avatar
      sepolicy: Allow apps to get info from priv_app by ashmem · fdfa42bf
      ji, zhenlong z authored
      This is used to address a CTS testcase failure. This CTS
      testcase need to access the content of Contact, some data
      from ContactProvider is transfered through ashmem.
      
      Currently ashmem is backed by the tmpfs filesystem, ContactProvider
      in android run as a priv_app, so the file context of the ashmem
      created by ContactProvider is priv_app_tmpfs. CTS runs as an
      untrusted_app, need to be granted the read permission to the
      priv_app_tmpfs files.
      
      Bug: 117961216
      
      [Android Version]:
      android_p_mr0_r0
      
      [Kernel Version]:
      4.19.0-rc8
      
      [CTS Version]:
      cts-9.0_r1
      
      [Failed Testcase]:
      com.android.cts.devicepolicy.ManagedProfileTest#testManagedContactsPolicies
      
      [Error Log]:
      11-11 11:15:50.479 12611 12611 W AndroidTestSuit: type=1400 audit(0.0:811):
      avc: denied { read } for path=2F6465762F6173686D656D202864656C6574656429
      dev="tmpfs" ino=174636 scontext=u:r:untrusted_app:s0:c113,c256,c522,c768
      tcontext=u:object_r:priv_app_tmpfs:s0:c522,c768 tclass=file permissive=0
      
      [Test Result With This Patch]:
      PASS
      
      Change-Id: I45efacabe64af36912a53df60ac059889fde1629
      fdfa42bf
  4. Oct 22, 2018
    • Treehugger Robot's avatar
    • Treehugger Robot's avatar
    • Tri Vo's avatar
      asan: restore global access to system_asan_options_file. · 3d2e200b
      Tri Vo authored
      Bug: 118161817
      Test: SANITIZE_TARGET=address m selinux_policy
      Change-Id: I4dabcb3692c59b810a06567e272bca9f0e9c3ecd
      3d2e200b
    • Joel Galenson's avatar
      Allow dumpstate to call mediaswcodec over binder · 33ded4a6
      Joel Galenson authored
      This prevents denials while taking a bugreport.
      
      Test: cts-tradefed run cts -m CtsSecurityHostTestCases -t
      android.security.cts.SELinuxHostTest#testNoBugreportDenials
      
      Change-Id: I381b39fa127f82fcef5d820a04209fd1ba4f63cd
      33ded4a6
    • Nick Kralevich's avatar
      update_engine_common: allow BLKROGET and BLKROSET · eacbcc98
      Nick Kralevich authored
      Allow BLKROGET and BLKROSET on the block devices underlying the /system
      and rootfs partitions. As part of the Android boot process, the system
      sets the block devices read-only to prevent accidental modification to
      these partitions. Update engine needs the ability to adjust the block
      device read-only flag in order to apply updates.
      
      Addresses the following denials:
      
      update_engine: type=1400 audit(0.0:96): avc: denied { ioctl } for path="/dev/block/sda33" dev="tmpfs" ino=15369 ioctlcmd=125e scontext=u:r:update_engine:s0 tcontext=u:object_r:system_block_device:s0 tclass=blk_file permissive=0
      update_engine: type=1400 audit(0.0:97): avc: denied { ioctl } for path="/dev/block/sda33" dev="tmpfs" ino=15369 ioctlcmd=125d scontext=u:r:update_engine:s0 tcontext=u:object_r:system_block_device:s0 tclass=blk_file permissive=0
      
      Test: policy compiles
      Bug: 118150702
      Change-Id: I65a3d041b6d6b7955bcd901637a543524fc34a06
      eacbcc98
    • Treehugger Robot's avatar
      2779f92c
    • Treehugger Robot's avatar
      faba4312
    • Nick Kralevich's avatar
      fastbootd.te: Delete allowxperm statement · 392ac0fd
      Nick Kralevich authored
      system/sepolicy commit 4c8eaba7, reviewed in
      https://android-review.googlesource.com/c/platform/system/sepolicy/+/793958
      started enforcing explicit ioctl permission checks for all block device
      files. As part of that commit, the following lines were added to
      domain.te:
      
        # If a domain has access to perform an ioctl on a block device, allow these
        # very common, benign ioctls
        allowxperm domain dev_type:blk_file ioctl { BLKGETSIZE64 BLKSSZGET };
      
      In essence, if a domain is granted ioctl access to any device in
      policy (for example, via adding "ioctl" to the allow rule, or by using
      the macro "r_file_perms" which includes the ioctl permission), then the
      two ioctls BLKGETSIZE64 and BLKSSZGET will be automatically allowed. As
      such, it is redundent for a domain to explicitly request these two
      ioctls.
      
      Delete the now redundant allowxperm rule.
      
      Test: policy compiles
      Change-Id: I1964ed93a7c7601393cc9e2416f3640ea22db51b
      392ac0fd
  5. Oct 20, 2018
  6. Oct 19, 2018
Loading