Skip to content
Snippets Groups Projects
  1. Apr 13, 2018
    • Joel Galenson's avatar
      Track storaged SELinux denial. · 2b840913
      Joel Galenson authored
      This should help fix presubmit tests.
      
      Bug: 77634061
      Test: Built policy.
      Change-Id: Ib9f15c93b71c2b67f25d4c9f949a5e2b3ce93b9c
      (cherry picked from commit c6b5a96b)
      2b840913
    • Joel Galenson's avatar
      Allow some vold_prepare_subdirs denials. · 44b6a7c3
      Joel Galenson authored
      This addresses the following denials:
      
      avc: denied { fowner } for comm="rm" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:r:vold_prepare_subdirs:s0 tclass=capability
      avc: denied { getattr } for comm="rm" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:object_r:storaged_data_file:s0 tclass=file
      avc: denied { relabelfrom } for comm="vold_prepare_su" name="storaged" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:object_r:system_data_file:s0 tclass=dir
      avc: denied { getattr } for comm="rm" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:object_r:system_data_file:s0 tclass=file
      
      Bug: 77875245
      Test: Boot device.
      Test: Mislabel directories used by vold_prepare_subdirs, reboot, and
      ensure it can relabel them without denials.
      Test: Add user, reboot, delete user, reboot, observe no denials.
      
      (cherry picked from commit 855dd5a8)
      
      Merged-In: Id67bc99f151a6ccb9619bbfb7080452956405121
      Change-Id: Ic86be1e1afed37602255448e5700811d197403f9
      44b6a7c3
    • Jaekyun Seok's avatar
      Whitelist vendor-init-settable bluetooth_prop and wifi_prop · a11b16c9
      Jaekyun Seok authored
      Values of the following properties are set by SoC vendors on some
      devices including Pixels.
      - persist.bluetooth.a2dp_offload.cap
      - persist.bluetooth.a2dp_offload.enable
      - persist.vendor.bluetooth.a2dp_offload.enable
      - ro.bt.bdaddr_path
      - wlan.driver.status
      
      So they should be whitelisted for compatibility.
      
      Bug: 77633703
      Test: succeeded building and tested with Pixels
      Change-Id: Ib2b81bcc1fd70ddd571dc7fb2b923b576d62b7d5
      Merged-In: Ib2b81bcc1fd70ddd571dc7fb2b923b576d62b7d5
      (cherry picked from commit 224921d1)
      a11b16c9
    • Jaekyun Seok's avatar
      Whitelist vendor-init-settable bluetooth_prop and wifi_prop · 224921d1
      Jaekyun Seok authored
      Values of the following properties are set by SoC vendors on some
      devices including Pixels.
      - persist.bluetooth.a2dp_offload.cap
      - persist.bluetooth.a2dp_offload.enable
      - persist.vendor.bluetooth.a2dp_offload.enable
      - ro.bt.bdaddr_path
      - wlan.driver.status
      
      So they should be whitelisted for compatibility.
      
      Bug: 77633703
      Test: succeeded building and tested with Pixels
      Change-Id: Ib2b81bcc1fd70ddd571dc7fb2b923b576d62b7d5
      224921d1
  2. Apr 11, 2018
    • Jeff Vander Stoep's avatar
      hal_tetheroffload: move hwservice mapping to core policy · c41f5b84
      Jeff Vander Stoep authored
      Addresses:
      avc: denied { find } for
      interface=android.hardware.tetheroffload.config::IOffloadConfig
      scontext=u:r:system_server:s0
      tcontext=u:object_r:default_android_hwservice:s0
      tclass=hwservice_manager
      
      Bug: 77855688
      Test: build/boot Sailfish, turn on tethering, no selinux denial
      Change-Id: I97cae0928b5311a4da41d19cbd5c863c3137a49f
      (cherry picked from commit 3a346ea7)
      c41f5b84
    • Jeff Vander Stoep's avatar
      hal_tetheroffload: move hwservice mapping to core policy · 3a346ea7
      Jeff Vander Stoep authored
      Addresses:
      avc: denied { find } for
      interface=android.hardware.tetheroffload.config::IOffloadConfig
      scontext=u:r:system_server:s0
      tcontext=u:object_r:default_android_hwservice:s0
      tclass=hwservice_manager
      
      Bug: 77855688
      Test: build/boot Sailfish, turn on tethering, no selinux denial
      Change-Id: I97cae0928b5311a4da41d19cbd5c863c3137a49f
      3a346ea7
    • Joel Galenson's avatar
      Allow some vold_prepare_subdirs denials. · 855dd5a8
      Joel Galenson authored
      This addresses the following denials:
      
      avc: denied { fowner } for comm="rm" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:r:vold_prepare_subdirs:s0 tclass=capability
      avc: denied { getattr } for comm="rm" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:object_r:storaged_data_file:s0 tclass=file
      avc: denied { relabelfrom } for comm="vold_prepare_su" name="storaged" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:object_r:system_data_file:s0 tclass=dir
      avc: denied { getattr } for comm="rm" scontext=u:r:vold_prepare_subdirs:s0 tcontext=u:object_r:system_data_file:s0 tclass=file
      
      Bug: 77875245
      Test: Boot device.
      Change-Id: Id67bc99f151a6ccb9619bbfb7080452956405121
      Test: Mislabel directories used by vold_prepare_subdirs, reboot, and
      ensure it can relabel them without denials.
      Test: Add user, reboot, delete user, reboot, observe no denials.
      855dd5a8
    • Jeff Vander Stoep's avatar
      Suppress spurious denial · 7e5ec2bc
      Jeff Vander Stoep authored
      Addresses:
      avc: denied { sys_resource } scontext=u:r:zygote:s0
      tcontext=u:r:zygote:s0 tclass=capability
      
      Bug: 77905989
      Test: build and flash taimen-userdebug
      Change-Id: If2413c3005df02a70661464d695211acbcda4094
      (cherry picked from commit 816e744d998cb327fbd20f3124b22398bea2b8e4)
      7e5ec2bc
    • Jeff Vander Stoep's avatar
      Suppress spurious denial · f7a7f7d1
      Jeff Vander Stoep authored
      Addresses:
      avc: denied { sys_resource } for comm="ip6tables" capability=24
      scontext=u:r:netutils_wrapper:s0 tcontext=u:r:netutils_wrapper:s0
      tclass=capability
      
      Bug: 77905989
      Test: build and flash taimen-userdebug
      Change-Id: Ic5d7c96152b96b55255eeec00b19948f38c1923c
      (cherry picked from commit 443a43c9)
      f7a7f7d1
    • Jeff Vander Stoep's avatar
      Suppress spurious denial · 443a43c9
      Jeff Vander Stoep authored
      Addresses:
      avc: denied { sys_resource } for comm="ip6tables" capability=24
      scontext=u:r:netutils_wrapper:s0 tcontext=u:r:netutils_wrapper:s0
      tclass=capability
      
      Bug: 77905989
      Test: build and flash taimen-userdebug
      Change-Id: Ic5d7c96152b96b55255eeec00b19948f38c1923c
      443a43c9
  3. Apr 10, 2018
    • Max Bires's avatar
      Merge "Adding ability for priv apps to read traceur fd" · a949ddb5
      Max Bires authored
      am: 8966b8e5
      
      Bug: 74435522
      Test: traceur can share to betterbug
      Change-Id: Ic24196b6a4050696d92f18a6879c569ccf5eaec7
      (cherry picked from commit f66fd522)
      a949ddb5
    • Jeff Vander Stoep's avatar
      priv_app: remove more logspam · 9dc1d538
      Jeff Vander Stoep authored
      avc: denied { read } for name="ext4" dev="sysfs" ino=32709
      scontext=u:r:priv_app:s0:c512,c768 tcontext=u:object_r:sysfs:s0
      tclass=dir permissive=0 b/72749888
      avc: denied { read } for name="state" dev="sysfs" ino=51318
      scontext=u:r:priv_app:s0:c512,c768
      tcontext=u:object_r:sysfs_android_usb:s0 tclass=file permissive=0
      b/72749888
      
      Bug: 72749888
      Test: build/boot taimen-userdebug. No more logspam
      Change-Id: Ic43d1c8b71e1e5e0e6f9af1e03816c4084120e7e
      Merged-In: Ic43d1c8b71e1e5e0e6f9af1e03816c4084120e7e
      (cherry picked from commit 558cdf1e)
      9dc1d538
    • Tri Vo's avatar
      Add internal types to 27.0[.ignore].cil. · fad493bf
      Tri Vo authored
      Bug: 69390067
      Test: manual run of treble_sepolicy_tests
      Change-Id: I1b772a3f7c96875765c75bfc1031f249411c3338
      Merged-In: I1b772a3f7c96875765c75bfc1031f249411c3338
      (cherry picked from commit 9fbd6520)
      fad493bf
    • Jeff Vander Stoep's avatar
      Start the process of locking down proc/net · 08731895
      Jeff Vander Stoep authored
      Files in /proc/net leak information. This change is the first step in
      determining which files apps may use, whitelisting benign access, and
      otherwise removing access while providing safe alternative APIs.
      
      To that end, this change:
      * Introduces the proc_net_type attribute which will assigned to any
      new SELinux types in /proc/net to avoid removing access to privileged
      processes. These processes may be evaluated later, but are lower
      priority than apps.
      * Labels /proc/net/{tcp,tcp6,udp,udp6} as proc_net_vpn due to existing
      use by VPN apps. This may be replaced by an alternative API.
      * Audits all other proc/net access for apps.
      * Audits proc/net access for other processes which are currently
      granted broad read access to /proc/net but should not be including
      storaged, zygote, clatd, logd, preopt2cachename and vold.
      
      Bug: 9496886
      Bug: 68016944
      Test: Boot Taimen-userdebug. On both wifi and cellular: stream youtube
          navigate maps, send text message, make voice call, make video call.
          Verify no avc "granted" messages in the logs.
      Test: A few VPN apps including "VPN Monster", "Turbo VPN", and
      "Freighter". Verify no logspam with the current setup.
      Test: atest CtsNativeNetTestCases
      Test: atest netd_integration_test
      Test: atest QtaguidPermissionTest
      Test: atest FileSystemPermissionTest
      
      Change-Id: I7e49f796a25cf68bc698c6c9206e24af3ae11457
      08731895
    • Florian Mayer's avatar
      Expose filesystem read events in SELinux policy. · 7ad383f1
      Florian Mayer authored
      Without this, we only have visibility into writes.
      
      Looking at traces, we realised for many of the files we care about (.dex, .apk)
      most filesystem events are actually reads.
      
      See aosp/661782 for matching filesystem permission change.
      
      Bug: 73625480
      
      Change-Id: I6ec71d82fad8f4679c7b7d38e3cb90aff0b9e298
      7ad383f1
  4. Apr 09, 2018
    • Max Bires's avatar
      Adding labeling for vendor security patch prop · 5cac1aa9
      Max Bires authored
      This will allow adb shell getprop ro.vendor.build.security_patch to
      properly return the correct build property, whereas previously it was
      offlimits due to lack of label.
      
      Test: adb shell getprop ro.vendor.build.security_patch successfully
      returns whatever VENDOR_SECURITY_PATCH is defined to be in the Android
      .mk files
      
      Change-Id: Ie8427738125fc7f909ad8d51e4b76558f5544d49
      5cac1aa9
    • Jeff Vander Stoep's avatar
      whitelist test failure that bypassed presubmit · 2ccd99a5
      Jeff Vander Stoep authored
      avc: denied { read } for comm="batterystats-wo" name="show_stat" dev="sysfs"
      scontext=u:r:system_server:s0 tcontext=u:object_r:sysfs:s0 tclass=file
      
      Bug: 77816522
      Test: build
      Change-Id: I50a9bfe1a9e4df9c84cf4b2b4aedbb8f82ac94cd
      2ccd99a5
    • Alan Stokes's avatar
      Revert "Add /sys/kernel/memory_state_time to sysfs_power." · 12e73685
      Alan Stokes authored
      This reverts commit db83323a.
      
      Reason for revert: breaks some builds due to duplicate genfs entries
      
      Change-Id: I47813bd84ff10074a32cf483501a9337f556e92a
      12e73685
    • Alan Stokes's avatar
      Installd doesn't need to create cgroup files. · 06bac37f
      Alan Stokes authored
      cgroupfs doesn't allow files to be created, so this can't be needed.
      
      Also remove redundant neverallow and dontaudit rules. These are now
      more broadly handled by domain.te.
      
      Bug: 74182216
      
      Test: Denials remain silenced.
      
      Change-Id: If7eb0e59f567695d987272a2fd36dbc251516e9f
      
      (cherry picked from commit 8e8c1093)
      06bac37f
    • Alan Stokes's avatar
      Add /sys/kernel/memory_state_time to sysfs_power. · db83323a
      Alan Stokes authored
      This allows system_server to access it for determining battery stats
      (see KernelMemoryBandwidthStats.java).
      
      batterystats-wo: type=1400 audit(0.0:429): avc: denied { read } for name="show_stat" dev="sysfs" ino=48071 scontext=u:r:system_server:s0 tcontext=u:object_r:sysfs:s0 tclass=file permissive=0
      
      Bug: 72643420
      Bug: 73947096
      
      Test: Denial is no longer present.
      Change-Id: Ibe46aee48eb3f78fa5a9d1f36602c082c33036f7
      
      (cherry picked from commit a8b3634d)
      db83323a
  5. Apr 06, 2018
    • Mikhail Naganov's avatar
      Add shell:fifo_file permission for audioserver · 05e12dba
      Mikhail Naganov authored
      Bug: 73405145
      Test: cts-tradefed run cts -m CtsMediaTestCases -t android.media.cts.AudioRecordTest#testRecordNoDataForIdleUids
      Change-Id: I09bdb74c9ecc317ea090643635ca26165efa423a
      (cherry picked from commit c5815891)
      Merged-In: I09bdb74c9ecc317ea090643635ca26165efa423a
      05e12dba
    • Mikhail Naganov's avatar
      Add shell:fifo_file permission for audioserver · c5815891
      Mikhail Naganov authored
      Bug: 73405145
      Test: cts-tradefed run cts -m CtsMediaTestCases -t android.media.cts.AudioRecordTest#testRecordNoDataForIdleUids
      Change-Id: I09bdb74c9ecc317ea090643635ca26165efa423a
      c5815891
    • Florian Mayer's avatar
      Grant traced_probes search on directories. · 269c9665
      Florian Mayer authored
      This is needed to be able to scan the labels we have
      permission on.
      
      Denial:
      
      04-06 12:52:22.674   874   874 W traced_probes: type=1400 audit(0.0:10314): avc: denied { search } for name="backup" dev="sda45" ino=6422529 scontext=u:r:traced_probes:s0 tcontext=u:object_r:backup_data_file:s0 tclass=dir permissive=0
      
      Bug: 73625480
      
      cherry-picked from aosp/658243
      Change-Id: I52f3865952004bfc6fe22c488d768276866f8ae1
      Merged-In: I52f3865952004bfc6fe22c488d768276866f8ae1
      269c9665
    • Florian Mayer's avatar
      Grant traced_probes search on directories. · ff146962
      Florian Mayer authored
      This is needed to be able to scan the labels we have
      permission on.
      
      Denial:
      
      04-06 12:52:22.674   874   874 W traced_probes: type=1400 audit(0.0:10314): avc: denied { search } for name="backup" dev="sda45" ino=6422529 scontext=u:r:traced_probes:s0 tcontext=u:object_r:backup_data_file:s0 tclass=dir permissive=0
      
      Bug: 73625480
      ff146962
    • Alan Stokes's avatar
      Installd doesn't need to create cgroup files. · 8e8c1093
      Alan Stokes authored
      cgroupfs doesn't allow files to be created, so this can't be needed.
      
      Also remove redundant neverallow and dontaudit rules. These are now
      more broadly handled by domain.te.
      
      Bug: 74182216
      
      Test: Denials remain silenced.
      
      Change-Id: If7eb0e59f567695d987272a2fd36dbc251516e9f
      8e8c1093
    • Alan Stokes's avatar
      Add /sys/kernel/memory_state_time to sysfs_power. · a8b3634d
      Alan Stokes authored
      This allows system_server to access it for determining battery stats
      (see KernelMemoryBandwidthStats.java).
      
      batterystats-wo: type=1400 audit(0.0:429): avc: denied { read } for name="show_stat" dev="sysfs" ino=48071 scontext=u:r:system_server:s0 tcontext=u:object_r:sysfs:s0 tclass=file permissive=0
      
      Bug: 72643420
      Bug: 73947096
      
      Test: Denial is no longer present.
      Change-Id: Ibe46aee48eb3f78fa5a9d1f36602c082c33036f7
      a8b3634d
  6. Apr 05, 2018
  7. Apr 04, 2018
    • Jeff Vander Stoep's avatar
      priv_app: remove more logspam · 558cdf1e
      Jeff Vander Stoep authored
      avc: denied { read } for name="ext4" dev="sysfs" ino=32709
      scontext=u:r:priv_app:s0:c512,c768 tcontext=u:object_r:sysfs:s0
      tclass=dir permissive=0 b/72749888
      avc: denied { read } for name="state" dev="sysfs" ino=51318
      scontext=u:r:priv_app:s0:c512,c768
      tcontext=u:object_r:sysfs_android_usb:s0 tclass=file permissive=0
      b/72749888
      
      Bug: 72749888
      Test: build/boot taimen-userdebug. No more logspam
      Change-Id: Ic43d1c8b71e1e5e0e6f9af1e03816c4084120e7e
      558cdf1e
    • Kweku Adams's avatar
      Allowing incidentd to get stack traces from processes. · 985db6d8
      Kweku Adams authored
      Bug: 72177715
      Test: flash device and check incident output
      Change-Id: I16c172caec235d985a6767642134fbd5e5c23912
      985db6d8
  8. Apr 03, 2018
    • Nathan Harold's avatar
      Allow getsockopt and setsockopt for Encap Sockets · 252b0153
      Nathan Harold authored
      Because applications should be able to set the receive
      timeout on UDP encapsulation sockets, we need to allow
      setsockopt(). getsockopt() is an obvious allowance as
      well.
      
      Bug: 68689438
      Test: compilation
      Merged-In: I2eaf72bcce5695f1aee7a95ec03111eca577651c
      Change-Id: I2eaf72bcce5695f1aee7a95ec03111eca577651c
      252b0153
    • Jeff Vander Stoep's avatar
      Rename qtaguid_proc to conform to name conventions · bdf2a9c4
      Jeff Vander Stoep authored
      Test: build
      Bug: 68774956
      Change-Id: I0f9fd87eb41e67e14f35e49eba13e3d1de745250
      bdf2a9c4
    • Jeff Vander Stoep's avatar
      Rename qtaguid_proc to conform to name conventions · 27b32ac6
      Jeff Vander Stoep authored
      Test: build
      Bug: 68774956
      Change-Id: I0f9fd87eb41e67e14f35e49eba13e3d1de745250
      (cherry picked from commit 5f650f581a2699bb2d5aaaa4675d651eb47c1c16)
      27b32ac6
    • Jeff Vander Stoep's avatar
      Add untrusted_app_27 · 3aa7ca56
      Jeff Vander Stoep authored
      This is a partial cherry pick of commit 6231b4d9
      'Enforce per-app data protections for targetSdk 28+'.
      
      Untrusted_app_27 remains unreachable, but it's existence
      prevents future merge conflicts.
      
      Bug: 63897054
      Test: build/boot aosp_walleye-userdebug
      Change-Id: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      Merged-In: I64b013874fe87b55f47e817a1279e76ecf86b7c0
      (cherry picked from commit 6231b4d9)
      3aa7ca56
    • Nathan Harold's avatar
      Allow getsockopt and setsockopt for Encap Sockets · ea4eaaf1
      Nathan Harold authored
      Because applications should be able to set the receive
      timeout on UDP encapsulation sockets, we need to allow
      setsockopt(). getsockopt() is an obvious allowance as
      well.
      
      Bug: 68689438
      Test: compilation
      Change-Id: I2eaf72bcce5695f1aee7a95ec03111eca577651c
      ea4eaaf1
    • Jeff Vander Stoep's avatar
      Remove deprecated tagSocket() permissions · 0d1e52a5
      Jeff Vander Stoep authored
      tagSocket() now results in netd performing these actions on behalf
      of the calling process.
      
      Remove direct access to:
      /dev/xt_qtaguid
      /proc/net/xt_qtaguid/ctrl
      
      Bug: 68774956
      Test: -m CtsAppSecurityHostTestCases -t android.appsecurity.cts.AppSecurityTests
          -m CtsNativeNetTestCases
      Test: stream youtube, browse chrome
      Test: go/manual-ab-ota
      Change-Id: I6a044f304c3ec4e7c6043aebeb1ae63c9c5a0beb
      0d1e52a5
  9. Mar 31, 2018
  10. Mar 30, 2018
    • yro's avatar
      Update sepolicy to have system_server access stats_data · 36dd2a41
      yro authored
      Test: manually tested to prevent sepolicy violation
      Change-Id: I9ebcc86464a9fc61a49d5c9be40f19f3523b6785
      36dd2a41
    • Chenbo Feng's avatar
      Allow netutils_wrapper to use pinned bpf program · be9b15c5
      Chenbo Feng authored
      The netutils_wrapper is a process used by vendor code to update the
      iptable rules on devices. When it update the rules for a specific chain.
      The iptable module will reload the whole chain with the new rule. So
      even the netutils_wrapper do not need to add any rules related to xt_bpf
      module, it will still reloading the existing iptables rules about xt_bpf
      module and need pass through the selinux check again when the rules are
      reloading. So we have to grant it the permission to reuse the pinned
      program in fs_bpf when it modifies the corresponding iptables chain so
      the vendor module will not crash anymore.
      
      Test: device boot and no more denials from netutils_wrapper
      Bug: 72111305
      Change-Id: I62bdfd922c8194c61b13e2855839aee3f1e349be
      (cherry picked from aosp commit 2623ebcf)
      be9b15c5
    • Yi Jin's avatar
      Allow incidentd to read LAST_KMSG only for userdebug builds · 76238cd4
      Yi Jin authored
      Bug: 73354384
      Test: manual
      Change-Id: Iaaeded69c287eae757aaf68dc18bc5a0c53b94e6
      76238cd4
Loading