Skip to content
Snippets Groups Projects
  1. Jun 07, 2018
  2. Jun 06, 2018
    • Tri Vo's avatar
      Mechanism to exclude neverallows from *TS. · 77c44fc4
      Tri Vo authored
      build_test_only is used to denote rules that should not verified
      as part of compliance testing.
      
      Use this macro to exclude neverallow rules which we want to check as
      part of build, but not CTS.
      
      Bug: 80499271
      Test: SELinuxNeverallowRulesTest on walleye has no more failure of type
      "Type or attribute * used in neverallow undefined in policy being checked."
      Number of failing test cases is reduced by 142.
      Test: policy.conf used to check neverallows at build-time still retains
      all neverallow rules.
      Change-Id: I5f1b383d9096bb5a7b8c0f1bc008b5dd07419580
      77c44fc4
    • Treehugger Robot's avatar
      Merge changes from topic "b80319537" · 0578a394
      Treehugger Robot authored
      * changes:
        hal_attribute_hwservice_client drop '_client'
        hal_attribute_hwservice_client += add_hwservice
      0578a394
    • Treehugger Robot's avatar
      Merge "Deprivilege haiku" · 59f8e75a
      Treehugger Robot authored
      59f8e75a
    • Steven Moreland's avatar
      hal_attribute_hwservice_client drop '_client' · 9234e00d
      Steven Moreland authored
      Since this attribute just associates a hal_attribute
      with a given hwservice in the standard way.
      
      Bug: 80319537
      Test: boot + sanity + test for denials
      Change-Id: I545de165515387317e6920ce8f5e8c491f9ab24e
      9234e00d
    • Steven Moreland's avatar
      hal_attribute_hwservice_client += add_hwservice · 343e24a1
      Steven Moreland authored
      For sanity, this makes 'hal_attribute_hwservice_client'
      be associated with a specific hwservice thus making things
      consistent.
      
      After this change, only configstore, hal_allocator, and the
      fwk_* services are inconsistent with all other HALs.
      
      Bug: 80319537
      Test: boot device, sanity tests, check for denials
      Change-Id: Ibffc65c9567a429e07a3dc4dd41117738459dc2a
      343e24a1
    • Treehugger Robot's avatar
  3. Jun 05, 2018
  4. Jun 04, 2018
    • Treehugger Robot's avatar
    • Steven Moreland's avatar
      Add context for ro.boot.product.hardware.sku. · d47b09f1
      Steven Moreland authored
      This was defined, but it had no users in the Android tree.
      Because of this, ODM manifests required extra sepolicy to be applied
      in vendor. Before this, there was no policy split, so that was okay,
      but now it is impossible.
      
      Bug: 91735839
      Test: add an odm manifest for SE conditional on
          a system property (ro.boot.product.hardware.sku)
          and make sure it is read into the manifest (using
          the vintf tool) and also that a client can get the
      $ lshal | grep secure
      Y android.hardware.secure_element@1.0::ISecureElement/SIM1                                  0/2        881    2262 567
      
      Change-Id: I94a2928943be6a17416b8bbd78106809c0c21198
      Merged-In: I94a2928943be6a17416b8bbd78106809c0c21198
      d47b09f1
    • Neil Fuller's avatar
      selinux changes to add time detector service · e1dd6d07
      Neil Fuller authored
      This commit contains the changes needed to add the new
      time detector system server service.
      
      Bug: 78217059
      Test: make / booted device
      Change-Id: I7cfaac6cac876e4aa73e8af1aa5f837117bb9ad7
      e1dd6d07
    • Jeff Vander Stoep's avatar
      Deprivilege haiku · f45db06c
      Jeff Vander Stoep authored
      Clatd and zygote
      are all overprivileged
      as is storaged
      
      Test: Verify no "granted" messages from dogfooders. Build flash
      aosp_taimen-userdebug. Verify no denials.
      Change-Id: I735adcffed553962ad12072716a7200883930dcf
      f45db06c
  5. Jun 01, 2018
    • Jeff Vander Stoep's avatar
      Suppress denials for apps accessing storage too early · 9c7396d5
      Jeff Vander Stoep authored
      The recommended solution is to not access encrypted storage until
      after the ACTION_USER_UNLOCKED intent is delivered.
      
      Test: build
      Fixes: 72811052
      Fixes: 72550646
      Change-Id: I80eb743e26047b7864de983c5a46c28b6f753a59
      9c7396d5
    • Jiyong Park's avatar
      add extended_core_property_type · d8ae0071
      Jiyong Park authored
      The attribute is used to capture system properties added from outside of
      AOSP (e.g. by OEM), but are not device-specific and thus are used only
      inside the system partition.
      
      Access to the the system properties from outside of the system partition
      is prevented by the neverallow rule.
      
      Bug: 80382020
      Bug: 78598545
      Test: m -j selinux_policy
      Merged-In: I22c083dc195dab84c9c21a79fbe3ad823a3bbb46
      Change-Id: I22c083dc195dab84c9c21a79fbe3ad823a3bbb46
      (cherry picked from commit c0f8f2f8)
      d8ae0071
    • Tom Cherry's avatar
      neverallow coredomain from writing vendor properties · 5897e23e
      Tom Cherry authored
      System properties can be abused to get around Treble requirements of
      having a clean system/vendor split.  This CL seeks to prevent that by
      neverallowing coredomain from writing vendor properties.
      
      Bug: 78598545
      Test: build 2017 Pixels
      Test: build aosp_arm64
      Change-Id: I5e06894150ba121624d753228e550ba9b81f7677
      (cherry picked from commit cdb1624c)
      5897e23e
  6. May 31, 2018
  7. May 30, 2018
    • Steven Moreland's avatar
      Find hal_foo_hwservice -> you are hal_foo_client. · 8fc79818
      Steven Moreland authored
      Before, it was possible to access a hwservice without declaring
      that you were a client.
      
      This introduces the following macro:
      hal_attribute_hwservice_client(hal_foo, hal_foo_hwservice)
      
      which makes sure the above implication holds using a neverallow rule.
      
      Bug: 80319537
      Test: boot + sanity
      Change-Id: Iededae68f14f0f3bd412c1205aa3b650a54d55c6
      8fc79818
    • Steven Moreland's avatar
      mediacodec->mediacodec+hal_omx{,_server,_client} · 7baf725e
      Steven Moreland authored
      (breaks vendor blobs, will have to be regenerated
      after this CL)
      
      This moves mediacodec to vendor so it is replaced with
      hal_omx_server. The main benefit of this is that someone
      can create their own implementation of mediacodec without
      having to alter the one in the tree. mediacodec is still
      seccomp enforced by CTS tests.
      
      Fixes: 36375899
      Test: (sanity) YouTube
      Test: (sanity) camera pics + video
      Test: check for denials
      Change-Id: I31f91b7ad6cd0a891a1681ff3b9af82ab400ce5e
      7baf725e
    • Treehugger Robot's avatar
      db459a1b
  8. May 29, 2018
    • Jeff Vander Stoep's avatar
      Improve tests protecting private app data · ab82125f
      Jeff Vander Stoep authored
      In particular, add assertions limiting which processes may
      directly open files owned by apps. Reduce this to just apps, init,
      and installd. App data is protected by a combination of selinux
      permissions and Unix permissions, so limiting the open permission to
      just apps (which are not allowed to have CAP_DAC_OVERRIDE or
      CAP_DAC_READ_SEARCH) ensures that only installd and init have
      complete access an app's private directory.
      
      In addition to apps/init/installd, other processes currently granted
      open are mediaserver, uncrypt, and vold. Uncrypt's access appears to
      be deprecated (b/80299612). Uncrypt now uses /data/ota_package
      instead. b/80418809 and b/80300620 track removal for vold and
      mediaserver.
      
      Test: build/boot aosp_taimen-userdebug. Verify no "granted" audit
      messages in the logs.
      Bug: 80190017
      Bug: 80300620
      Bug: 80418809
      Fixes: 80299612
      Change-Id: I153bc7b62294b36ccd596254a5976dd887fed046
      ab82125f
  9. May 24, 2018
  10. May 22, 2018
  11. May 21, 2018
  12. May 18, 2018
  13. May 17, 2018
Loading