Skip to content
Snippets Groups Projects
  1. May 30, 2018
    • Steven Moreland's avatar
      mediacodec->mediacodec+hal_omx{,_server,_client} · 7baf725e
      Steven Moreland authored
      (breaks vendor blobs, will have to be regenerated
      after this CL)
      
      This moves mediacodec to vendor so it is replaced with
      hal_omx_server. The main benefit of this is that someone
      can create their own implementation of mediacodec without
      having to alter the one in the tree. mediacodec is still
      seccomp enforced by CTS tests.
      
      Fixes: 36375899
      Test: (sanity) YouTube
      Test: (sanity) camera pics + video
      Test: check for denials
      Change-Id: I31f91b7ad6cd0a891a1681ff3b9af82ab400ce5e
      7baf725e
  2. May 29, 2018
    • Jeff Vander Stoep's avatar
      Improve tests protecting private app data · ab82125f
      Jeff Vander Stoep authored
      In particular, add assertions limiting which processes may
      directly open files owned by apps. Reduce this to just apps, init,
      and installd. App data is protected by a combination of selinux
      permissions and Unix permissions, so limiting the open permission to
      just apps (which are not allowed to have CAP_DAC_OVERRIDE or
      CAP_DAC_READ_SEARCH) ensures that only installd and init have
      complete access an app's private directory.
      
      In addition to apps/init/installd, other processes currently granted
      open are mediaserver, uncrypt, and vold. Uncrypt's access appears to
      be deprecated (b/80299612). Uncrypt now uses /data/ota_package
      instead. b/80418809 and b/80300620 track removal for vold and
      mediaserver.
      
      Test: build/boot aosp_taimen-userdebug. Verify no "granted" audit
      messages in the logs.
      Bug: 80190017
      Bug: 80300620
      Bug: 80418809
      Fixes: 80299612
      Change-Id: I153bc7b62294b36ccd596254a5976dd887fed046
      ab82125f
  3. May 22, 2018
    • Tom Cherry's avatar
      Finer grained permissions for ctl. properties · 7b8be35d
      Tom Cherry authored
      Currently, permissions for ctl. property apply to each action verb, so
      if a domain has permissions for controlling service 'foo', then it can
      start, stop, and restart foo.
      
      This change implements finer grainer permissions such that permission
      can be given to strictly start a given service, but not stop or
      restart it.  This new permission scheme is mandatory for the new
      control functions, sigstop_on, sigstop_off, interface_start,
      interface_stop, interface_restart.
      
      Bug: 78511553
      Test: see appropriate successes and failures based on permissions
      Merged-In: Ibe0cc0d6028fb0ed7d6bcba626721e0d84cc20fa
      Change-Id: Ibe0cc0d6028fb0ed7d6bcba626721e0d84cc20fa
      (cherry picked from commit 2208f96e)
      7b8be35d
  4. May 21, 2018
  5. May 18, 2018
  6. May 17, 2018
  7. May 16, 2018
    • Wei Wang's avatar
      Allow dumpstate to kill dumpstate vendor HAL in timeout case · a1db36e1
      Wei Wang authored
      Bug: 77489941
      Test: simulate delay in dumpstate HAL and get BR, see below from dumpstate_log.txt
          dumpstateBoard timed out after 10s, killing dumpstate vendor HAL
          dumpstateBoard failed: Status(EX_TRANSACTION_FAILED): 'DEAD_OBJECT: '
      Change-Id: I90ed5cb8fe8da8ad21ae77676433936cb12d9d04
      (cherry picked from commit 60d17674)
      a1db36e1
    • Jeff Vander Stoep's avatar
      Fix diff in cherry-pick · 141b00fb
      Jeff Vander Stoep authored
      Changes 2d626fd84ea0246c963ce2c87ae62461a60f8826 and
      869562e9 are the same
      commit, but with a different comment. Fix them up to be
      the same.
      
      Test: build
      Change-Id: I6311413357f457d6ba95886b729ffa53ab80e016
      141b00fb
    • Andreas Huber's avatar
      Fingerprint data is now stored in one of two ways depending on the · 4d6a5e87
      Andreas Huber authored
      shipping API version:
      
      For devices shipped on O-MR1 nothing changes, data is stored
      under /data/system/users/<user-id>/fpdata/...
      
      Devices shipped from now on will instead store fingerprint data under
      /data/vendor_de/<user-id>/fpdata.
      
      Support for /data/vendor_de and /data/vendor_ce has been added to vold.
      
      Bug: 36997597
      Change-Id: Ibc7cc33b756f64abe68a749c0ada0ca4f6d92514
      Merged-In: Ibc7cc33b756f64abe68a749c0ada0ca4f6d92514
      Test: manually
      (cherry picked from commit 6116daa7)
      4d6a5e87
  8. May 15, 2018
    • Steven Moreland's avatar
      Allow dumpstate to be used as a lazy HAL. · db632b65
      Steven Moreland authored
      hwservicemanager lost the permission to tell init to
      start the dumpstate HAL when dumpstate was given this
      permission exclusively.
      
      Bug: 77489941 # problem introduced
      Bug: 78509314 # converting dumpstate to lazy hals
      
      Test: convert an instance of dumpstate into a lazy HAL,
          run bugreport, see denial, then add permission, and
          see bugreport start to work again.
      
      Change-Id: I033701d8306200bebc0f250afe3d08f9e6ab98a1
      (cherry picked from commit 0b1797b8)
      Merged-In: I033701d8306200bebc0f250afe3d08f9e6ab98a1
      db632b65
  9. May 14, 2018
    • Jerry Zhang's avatar
      Allow mediaprovider to search /mnt/media_rw · ddb89ab7
      Jerry Zhang authored
      Mtp needs access to this path in order to
      change files on an sdcard.
      
      Fixes denial:
      
      05-14 17:40:58.803  3004  3004 W MtpServer: type=1400 audit(0.0:46):
      avc: denied { search } for name="media_rw" dev="tmpfs" ino=10113
      scontext=u:r:mediaprovider:s0:c512,c768
      tcontext=u:object_r:mnt_media_rw_file:s0 tclass=dir permissive=0
      b/77925342 app=com.android.providers.media
      
      Bug: 77849654
      Test: no denials using mtp with emulated sdcard
      Change-Id: I27b5294fa211bb1eff6d011638b5fdc90334bc80
      ddb89ab7
  10. May 10, 2018
    • Andreas Gampe's avatar
      Sepolicy: Fix perfprofd permissions · 835881aa
      Andreas Gampe authored
      Let statsd find the service. The system server wants to read file
      attributes for the perfprofd dropbox file.
      
      Bug: 73175642
      Test: m
      Test: manual
      Change-Id: I0c0b1dac057af90fff440286226093ec15b5e247
      835881aa
    • Mark Salyzyn's avatar
      llkd: add live-lock daemon · e4b3e0b6
      Mark Salyzyn authored
      Introduce a standalone live-lock daemon (llkd), to catch kernel
      or native user space deadlocks and take mitigating actions.
      
      Test: llkd_unit_test
      Bug: 33808187
      Bug: 72838192
      Change-Id: If869ecd06e5ce7b04bba1dafd0a77971b71aa517
      e4b3e0b6
  11. May 09, 2018
    • Calin Juravle's avatar
      Allow system server to write profile snapshots in /data/misc/profman · 6ff0f490
      Calin Juravle authored
      The goal is to allow creating profile snapshots from the shell command in
      order to be able to write CTS tests.
      
      The system server will dump profiles for debuggable in /data/misc/profman
      from where they will be pulled and verified by CTS tests.
      
      Test: adb shell cmd package snapshot-profile com.android.vending
      Bug: 74081010
      
      (cherry picked from commit 687d5e46)
      
      Merged-In: I54690305284b92c0e759538303cb98c93ce92dd5
      Change-Id: I54690305284b92c0e759538303cb98c93ce92dd5
      6ff0f490
    • Paul Crowley's avatar
      Add wait_for_keymaster · 9f760306
      Paul Crowley authored
      Bug: 79228237
      Test: audit2allow finds no relevant denials on boot
      Merged-In: Ia80b77ba9a1ec2354127cd0ef68d50ebcf593fb0
      Change-Id: Ia80b77ba9a1ec2354127cd0ef68d50ebcf593fb0
      9f760306
  12. May 08, 2018
  13. May 07, 2018
    • Ray Essick's avatar
      give audioserver access to media.metrics · b85e382f
      Ray Essick authored
      Let the audioserver record metrics with media.metrics service.
      This is for 'audiopolicy' metrics.
      
      Bug: 78595399
      Test: record from different apps, see records in 'dumpsys media.metrics'
      Change-Id: Ie5c403d0e5ac8c6d614db5e7b700611ddd6d07e9
      Merged-In: I63f9d4ad2d2b08eb98a49b8de5f86b6797ba2995
      b85e382f
  14. May 04, 2018
    • Pavel Maltsev's avatar
      Move automotive HALs sepolicy to system/ · 43e172af
      Pavel Maltsev authored
      Bug: 70637118
      Test: build, flash and boot automotive builds
      
      Change-Id: I6db23258de30174d6db09d241e91b08aa5afedef
      Merged-In: I6db23258de30174d6db09d241e91b08aa5afedef
      (cherry picked from commit 394dbe34)
      43e172af
    • Pawin Vongmasa's avatar
      Put in sepolicies for Codec2.0 services · 19a74ec8
      Pawin Vongmasa authored
      Test: Builds
      
      Bug: 64121714
      Bug: 31973802
      Change-Id: Id37be8726a8bb297e35bca494964fdbcc48c6a73
      (cherry picked from commit 4be28894)
      19a74ec8
    • Jeff Vander Stoep's avatar
      Start the process of locking down proc/net · 7a4af30b
      Jeff Vander Stoep authored
      Files in /proc/net leak information. This change is the first step in
      determining which files apps may use, whitelisting benign access, and
      otherwise removing access while providing safe alternative APIs.
      
      To that end, this change:
      * Introduces the proc_net_type attribute which will assigned to any
      new SELinux types in /proc/net to avoid removing access to privileged
      processes. These processes may be evaluated later, but are lower
      priority than apps.
      * Labels /proc/net/{tcp,tcp6,udp,udp6} as proc_net_vpn due to existing
      use by VPN apps. This may be replaced by an alternative API.
      * Audits all other proc/net access for apps.
      * Audits proc/net access for other processes which are currently
      granted broad read access to /proc/net but should not be including
      storaged, zygote, clatd, logd, preopt2cachename and vold.
      
      Bug: 9496886
      Bug: 68016944
      Test: Boot Taimen-userdebug. On both wifi and cellular: stream youtube
          navigate maps, send text message, make voice call, make video call.
          Verify no avc "granted" messages in the logs.
      Test: A few VPN apps including "VPN Monster", "Turbo VPN", and
      "Freighter". Verify no logspam with the current setup.
      Test: atest CtsNativeNetTestCases
      Test: atest netd_integration_test
      Test: atest QtaguidPermissionTest
      Test: atest FileSystemPermissionTest
      
      Change-Id: I7e49f796a25cf68bc698c6c9206e24af3ae11457
      Merged-In: I7e49f796a25cf68bc698c6c9206e24af3ae11457
      (cherry picked from commit 08731895)
      7a4af30b
    • Roshan Pius's avatar
      sepolicy(hostapd): Add a HIDL interface for hostapd · d7b34a48
      Roshan Pius authored
      * Note on cherry-pick: Some of the dependent changes are not in AOSP.
      In order to keep hostapd running correctly in AOSP, I've modified this
      change to only include policy additions.
      
      Change sepolicy permissions to now classify hostapd as a HAL exposing
      HIDL interface.
      
      Sepolicy denial for accessing /data/vendor/misc/wifi/hostapd:
      12-27 23:40:55.913  4952  4952 W hostapd : type=1400 audit(0.0:19): avc:
      denied { write } for name="hostapd" dev="sda13" ino=4587601
      scontext=u:r:hal_wifi_hostapd_default:s0
      tcontext=u:object_r:system_data_file:s0 tclass=dir permissive=0
      
      01-02 19:07:16.938  5791  5791 W hostapd : type=1400 audit(0.0:31): avc:
      denied { search } for name="net" dev="sysfs" ino=30521
      scontext=u:r:hal_wifi_hostapd_default:s0
      tcontext=u:object_r:sysfs_net:s0 tclass=dir permissive=0
      
      Bug: 36646171
      Test: Device boots up and able to turn on SoftAp.
      Change-Id: Ibacfcc938deab40096b54b8d0e608d53ca91b947
      Merged-In: Ibacfcc938deab40096b54b8d0e608d53ca91b947
      (cherry picked from commit 5bca3e86)
      d7b34a48
    • Mark Salyzyn's avatar
      FrameworksServicesTests: allow access to test.sys.boot.reason property · 3443cafa
      Mark Salyzyn authored
      com.android.server.power.PowerManagerServiceTest#testGetLastShutdownReasonInternal due to "RuntimeException: failed to set system property"
      
      W/roidJUnitRunner: type=1400 audit(0.0:6): avc: denied { write } for name="property_service" dev="tmpfs" ino=13178 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:property_socket:s0 tclass=sock_file permissive=0
      W/libc    : Unable to set property "test.sys.boot.reason" to "shutdown,thermal": connection failed; errno=13 (Permission denied)
      
      Had to use precise property definition as com.android.phone accesses
      test properties as well.
      
      Test: compile
      Bug: 78245377
      Change-Id: I2cc810846f8615f2a2fae8e0d4f41de585b7abd7
      3443cafa
    • Jeffrey Vander Stoep's avatar
      9c6749d7
    • Calin Juravle's avatar
      Allow system server to record its own profile · 71d8467b
      Calin Juravle authored
      On userdebug builds we can now profile system server without disabling
      selinux. This is the final piece, and allows the system server to save its
      own profile.
      
      Test: manual, on a device with system server profiling enabled
      Bug: 73313191
      Change-Id: Iaf9575d3cda19ae4c38f1e20a8e1b9288b7abc83
      71d8467b
  15. May 03, 2018
    • yro's avatar
      Allow lmkd to log to statsd · db2e6085
      yro authored
      Bug: 78603347
      Test: build and locally tested
      Change-Id: Ib9b041af63d1fac7a689b932e7a2b202fa8d0f83
      db2e6085
    • Andreas Gampe's avatar
      Sepolicy: Fix system server calling perfprofd · 986b9af4
      Andreas Gampe authored
      Give all the right permissions to find and send a message to
      perfprofd from the system server.
      
      Bug: 73175642
      Test: m
      Test: manual
      Change-Id: I82b63ec097dcd445d9e8169fe0df4398d62ac184
      986b9af4
    • Mark Salyzyn's avatar
      FrameworksServicesTests: allow access to test.sys.boot.reason property · 0ab13a8d
      Mark Salyzyn authored
      com.android.server.power.PowerManagerServiceTest#testGetLastShutdownReasonInternal due to "RuntimeException: failed to set system property"
      
      W/roidJUnitRunner: type=1400 audit(0.0:6): avc: denied { write } for name="property_service" dev="tmpfs" ino=13178 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:property_socket:s0 tclass=sock_file permissive=0
      W/libc    : Unable to set property "test.sys.boot.reason" to "shutdown,thermal": connection failed; errno=13 (Permission denied)
      
      Test: compile
      Bug: 78245377
      Change-Id: Id21436d281bab27823969a9f7e92318d70b5a2d6
      0ab13a8d
  16. May 02, 2018
    • Tri Vo's avatar
      SELinux type for vendor public libs. · 29497b62
      Tri Vo authored
      Vendor public libs are exposed to apps (not system), and their ABI
      stability is guaranteed by vendor. Introducing new selinux type so that
      we don't conflate concepts of same-process HAL and vendor public lib.
      The former is exposed to all domains, while the latter should only be
      acessible by apps.
      
      Bug: 76413554
      Test: build-only change, policy builds
      Change-Id: I89dad351374f46c7fe2726991eb4c05064c37ed5
      29497b62
  17. May 01, 2018
    • Jeff Vander Stoep's avatar
      adbd: dontaudit sys_resource denials · 62166856
      Jeff Vander Stoep authored
      avc: denied { sys_resource } for comm="adbd" capability=24
      scontext=u:r:adbd:s0 tcontext=u:r:adbd:s0 tclass=capability
      
      Test: build aosp_sailfish-userdebug
      Bug: 78935353
      Change-Id: I094e54cbd61245d368f3164e30222dfdff902ffa
      62166856
  18. Apr 27, 2018
  19. Apr 26, 2018
    • Paul Crowley's avatar
      Allow vold_prepare_subdirs to delete more files. · 80966397
      Paul Crowley authored
      Bug: 78591623
      Test: Create a new user with a fingerprint. Reboot. Delete that user.
          Check for denials, files left over in /data/*_{c,d}e/10
      Merged-In: Ib818e112a98c5b954ee829e93ebd69c3b12940cf
      Change-Id: Ib818e112a98c5b954ee829e93ebd69c3b12940cf
      80966397
  20. Apr 25, 2018
  21. Apr 24, 2018
  22. Apr 23, 2018
  23. Apr 20, 2018
    • Joel Galenson's avatar
      Remove some priv_app logspam. · 9ec59f6c
      Joel Galenson authored
      avc: denied { search } for name="/" scontext=u:r:priv_app:s0:c512,c768 tcontext=u:object_r:fs_bpf:s0 tclass=dir permissive=0
      
      Bug: 72749888
      Test: Boot without seeing the denial.
      Change-Id: Iaf3559928473c68066e6a42ba71655a683861901
      9ec59f6c
  24. Apr 18, 2018
    • Jeff Vander Stoep's avatar
      Protect dropbox service data with selinux · 4d3ee1a5
      Jeff Vander Stoep authored
      Create a new label for /data/system/dropbox, and neverallow direct
      access to anything other than init and system_server.
      
      While all apps may write to the dropbox service, only apps with
      android.permission.READ_LOGS, a signature|privileged|development
      permission, may read them. Grant access to priv_app, system_app,
      and platform_app, and neverallow access to all untrusted_apps.
      
      Bug: 31681871
      Test: atest CtsStatsdHostTestCases
      Test: atest DropBoxTest
      Test: atest ErrorsTests
      Change-Id: Ice302b74b13c4d66e07b069c1cdac55954d9f5df
      4d3ee1a5
Loading