Skip to content
Snippets Groups Projects
Commit 5277d26c authored by Pierre LALET's avatar Pierre LALET
Browse files

DNS: follow the "default values that work" logic

  - recursion desired (DNS.rd) defaults to 1
  - question defaults to IN A for www.example.com (DNSQR.qname)
parent 9fce9b96
No related branches found
No related tags found
No related merge requests found
...@@ -239,7 +239,7 @@ class DNS(Packet): ...@@ -239,7 +239,7 @@ class DNS(Packet):
BitEnumField("opcode", 0, 4, {0:"QUERY",1:"IQUERY",2:"STATUS"}), BitEnumField("opcode", 0, 4, {0:"QUERY",1:"IQUERY",2:"STATUS"}),
BitField("aa", 0, 1), BitField("aa", 0, 1),
BitField("tc", 0, 1), BitField("tc", 0, 1),
BitField("rd", 0, 1), BitField("rd", 1, 1),
BitField("ra", 0, 1), BitField("ra", 0, 1),
BitField("z", 0, 1), BitField("z", 0, 1),
# AD and CD bits are defined in RFC 2535 # AD and CD bits are defined in RFC 2535
...@@ -288,9 +288,9 @@ dnsclasses = {1: 'IN', 2: 'CS', 3: 'CH', 4: 'HS', 255: 'ANY'} ...@@ -288,9 +288,9 @@ dnsclasses = {1: 'IN', 2: 'CS', 3: 'CH', 4: 'HS', 255: 'ANY'}
class DNSQR(Packet): class DNSQR(Packet):
name = "DNS Question Record" name = "DNS Question Record"
show_indent=0 show_indent=0
fields_desc = [ DNSStrField("qname",""), fields_desc = [DNSStrField("qname", "www.example.com"),
ShortEnumField("qtype", 1, dnsqtypes), ShortEnumField("qtype", 1, dnsqtypes),
ShortEnumField("qclass", 1, dnsclasses) ] ShortEnumField("qclass", 1, dnsclasses)]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment