From 5277d26cc8458b5d18054e8cd6c98cc1abc3d6dc Mon Sep 17 00:00:00 2001
From: Pierre LALET <pierre.lalet@cea.fr>
Date: Wed, 18 May 2016 11:28:47 +0200
Subject: [PATCH] DNS: follow the "default values that work" logic
- recursion desired (DNS.rd) defaults to 1
- question defaults to IN A for www.example.com (DNSQR.qname)
---
scapy/layers/dns.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scapy/layers/dns.py b/scapy/layers/dns.py
index 9abbf566..3fb93041 100644
--- a/scapy/layers/dns.py
+++ b/scapy/layers/dns.py
@@ -239,7 +239,7 @@ class DNS(Packet):
BitEnumField("opcode", 0, 4, {0:"QUERY",1:"IQUERY",2:"STATUS"}),
BitField("aa", 0, 1),
BitField("tc", 0, 1),
- BitField("rd", 0, 1),
+ BitField("rd", 1, 1),
BitField("ra", 0, 1),
BitField("z", 0, 1),
# AD and CD bits are defined in RFC 2535
@@ -288,9 +288,9 @@ dnsclasses = {1: 'IN', 2: 'CS', 3: 'CH', 4: 'HS', 255: 'ANY'}
class DNSQR(Packet):
name = "DNS Question Record"
show_indent=0
- fields_desc = [ DNSStrField("qname",""),
- ShortEnumField("qtype", 1, dnsqtypes),
- ShortEnumField("qclass", 1, dnsclasses) ]
+ fields_desc = [DNSStrField("qname", "www.example.com"),
+ ShortEnumField("qtype", 1, dnsqtypes),
+ ShortEnumField("qclass", 1, dnsclasses)]
--
GitLab