Commit 991ef53a authored by Tejun Heo's avatar Tejun Heo
Browse files

sched_ext: Make scx_rq_online() also test cpu_active() in addition to SCX_RQ_ONLINE



scx_rq_online() currently only tests SCX_RQ_ONLINE. This isn't fully correct
- e.g. consume_dispatch_q() uses task_run_on_remote_rq() which tests
scx_rq_online() to see whether the current rq can run the task, and, if so,
calls consume_remote_task() to migrate the task to @rq. While the test
itself was done while locking @rq, @rq can be temporarily unlocked by
consume_remote_task() and nothing prevents SCX_RQ_ONLINE from going offline
before the migration takes place.

To address the issue, add cpu_active() test to scx_rq_online(). There is a
synchronize_rcu() between cpu_active() being cleared and the rq going
offline, so if an on-going scheduling operation sees cpu_active(), the
associated rq is guaranteed to not go offline until the scheduling operation
is complete.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Fixes: 60c27fb5 ("sched_ext: Implement sched_ext_ops.cpu_online/offline()")
Acked-by: default avatarDavid Vernet <void@manifault.com>
parent 72763ea3
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment