Commit fc77d7ba authored by Miaoqing Pan's avatar Miaoqing Pan
Browse files

mhi: core: fix __local_bh_enable_ip warning



Invalid value of flags for spin_lock_irqsave(), which will cause
irq in unpredictability state. So when the irq is disabled, below
error will be triggered.

IRQs not enabled as expected
WARNING: CPU: 4 PID: 343 at kernel/softirq.c:161 __local_bh_enable_ip+0x140/0x154
CPU: 4 PID: 343 Comm: kworker/u16:15 Tainted: G S         O      4.19.157 #1
Hardware name: Qualcomm Technologies, Inc. qrb5165 IOT RB5 (DT)
Workqueue: cnss_driver_event cnss_driver_event_work
pstate: 60c00385 (nZCv DAIf +PAN +UAO)
pc : __local_bh_enable_ip+0x140/0x154
lr : __local_bh_enable_ip+0x140/0x154
sp : ffffff8019f3b650
x29: ffffff8019f3b650 x28: 0000000000000000
x27: 0000000000a030b0 x26: ffffff8019f3b790
x25: ffffff801ad0310c x24: ffffffe10a065208
x23: ffffff99010aec48 x22: 0000000000000002
x21: ffffffe109de5d40 x20: ffffff98fec70348
x19: 0000000000000201 x18: 0000000000000000
x17: ffffff9901fe2000 x16: 00000000fffcdbf8
x15: 00000000000cdbf8 x14: 0000000000000000
x13: 0000000000000000 x12: 00000000000000e0
x11: 0000000000000000 x10: 0000000000000001
x9 : 438504c404dc0200 x8 : 438504c404dc0200
x7 : ffffff98fe7809d8 x6 : 0000000000000000
x5 : 0000000000000080 x4 : 0000000000000001
x3 : 0000000000000000 x2 : 0000000000000007
x1 : 0000000000000007 x0 : 000000000000001c
Call trace:
 __local_bh_enable_ip+0x140/0x154
 _raw_read_unlock_bh+0x3c/0x48
 mhi_device_put+0xc4/0x138
 cnss_pci_force_wake_release+0x54/0x7c
 pld_force_wake_release+0x50/0x88 [wlan]
 hal_srng_setup+0x854/0x9a8 [wlan]
 ce_ring_setup_srng+0xfc/0x270 [wlan]
 ce_init+0x4fc/0x7d0 [wlan]
 hif_config_ce+0x120/0x330 [wlan]
 hif_pci_bus_configure+0xf8/0x218 [wlan]
 hif_bus_configure+0x24/0x30 [wlan]
 hif_enable+0x6c/0x1b8 [wlan]
 hdd_hif_open+0xf8/0x2f0 [wlan]
 hdd_wlan_start_modules+0xdc/0xa38 [wlan]
 hdd_wlan_startup+0x13c/0x490 [wlan]
 wlan_hdd_pld_probe+0x1c4/0x2c8 [wlan]
 pld_pcie_probe+0x60/0x78 [wlan]
 cnss_pci_call_driver_probe+0x74/0x2c8
 cnss_bus_call_driver_probe+0x28/0x7c
 cnss_driver_event_work+0x2f0/0xcd8
 process_one_work+0x398/0x680
 worker_thread+0x23c/0x4c4
 kthread+0x14c/0x15c
 ret_from_fork+0x10/0x18

Change-Id: Ifd29723e969627c280666147a9d7769046fa43d3
Signed-off-by: default avatarMiaoqing Pan <quic_miaoqing@quicinc.com>
parent a925a1e9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment