Commit f8b53cc9 authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Ard Biesheuvel
Browse files

efi: Fix .data section size calculations when .sbat is present



Commit 0f9a1739 ("efi: zboot specific mechanism for embedding SBAT
section") neglected to adjust the sizes of the .data section when
CONFIG_EFI_SBAT_FILE is set. As the result, the produced PE binary is
incorrect and some tools complain about it. E.g. 'sbsign' reports:

 # sbsign --key my.key --cert my.crt arch/arm64/boot/vmlinuz.efi
 warning: file-aligned section .data extends beyond end of file
 warning: checksum areas are greater than image size. Invalid section table?

Note, '__data_size' is also used in the PE optional header and it is not
entirely clear whether .sbat needs to be accounted as part of
SizeOfInitializedData or not. As the header seems to be unused by the real
world firmware, keeping the field equal to __data_size.

Fixes: 0f9a1739 ("efi: zboot specific mechanism for embedding SBAT section")
Reported-by: default avatarHeinrich Schuchardt <heinrich.schuchardt@gmx.de>
Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent c33453d0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment