Commit ec3e1ef0 authored by Carlos Llamas's avatar Carlos Llamas Committed by Lee Jones
Browse files

FROMLIST: binder: check offset alignment in binder_get_object()



Commit 6d98eb95 ("binder: avoid potential data leakage when copying
txn") introduced changes to how binder objects are copied. In doing so,
it unintentionally removed an offset alignment check done through calls
to binder_alloc_copy_from_buffer() -> check_buffer().

These calls were replaced in binder_get_object() with copy_from_user(),
so now an explicit offset alignment check is needed here. This avoids
later complications when unwinding the objects gets harder.

It is worth noting this check existed prior to commit 7a67a393
("binder: add function to copy binder object from buffer"), likely
removed due to redundancy at the time.

Fixes: 6d98eb95 ("binder: avoid potential data leakage when copying txn")
Cc:  <stable@vger.kernel.org>
Acked-by: default avatarTodd Kjos <tkjos@google.com>
Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>

Bug: 320661088
Bug: 332642003
Link: https://lore.kernel.org/all/20240330190115.1877819-1-cmllamas@google.com/


Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
Change-Id: Iaddabaa28de7ba7b7d35dbb639d38ca79dbc5077
Bug: 332642003
Signed-off-by: default avatarPindar Yang <pindaryang@google.com>
(cherry picked from commit 7859c5c9)
Signed-off-by: default avatarLee Jones <joneslee@google.com>
parent 48a0daf2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment