Commit e7e9b1bb authored by Yifan Hong's avatar Yifan Hong
Browse files

ANDROID: Prefer DTC from PATH.



This reverts commit dc39b233,
as well as fixing legacy usage from checkpatch_presbumit.sh.
Reason for revert: relanding change

This change deviates from 2a2cffe9
("ANDROID: Use DTC from PATH.") to allow missing DTC
because there may be usages that directly `source _setup_env.sh`
without setting up PATH with Kleaf's hermetic tools.
One such usage is the legacy checkpatch.sh and
checkpatch_presubmit.sh.

Below is the original commit message.

ANDROID: Use DTC from PATH.

Instead of using a hard-coded path to DTC, infer its
path from PATH. This change removes the dependency on
the ${BUILDTOOLS_PREBUILT_BIN}/dtc symlink, so the
build infrastructure is free to reset PATH to a place
where the actual DTC binary exists.

This change is needed to set
--incompatible_disable_hermetic_tools_symlink_source
to true by default.

Test: bazel run //common:db845c_dist
Fixes: a71e480e ("ANDROID: build.config: Set DTC to absolute path")
Bug: 291816237
Bug: 296265825
Change-Id: Ibb1be6c2b8f2f9d8a09bdc2187d392925c082fe0
Signed-off-by: default avatarYifan Hong <elsk@google.com>
(cherry picked from commit cd4ca8ca)
parent ff3aef0a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment