Unverified Commit e2fc0587 authored by Dragan Simic's avatar Dragan Simic Committed by Mark Brown
Browse files

spi: rockchip: Use dev_{err,warn}_probe() in the probe path



Use function dev_err_probe() in the probe path instead of dev_err() where
appropriate, to make the code a bit more uniform and compact.  Use the new
function dev_warn_probe() to improve error handling for the TX and RX DMA
channel requests, which are actually optional, and tweak the logged warnings
a bit to additionally describe their optional nature.

Previously, deferred requests for the TX and RX DMA channels produced no
debug messages, and the final error messages didn't include the error codes,
which are all highly useful when debugging permanently failed DMA channel
requests, such as when the required drivers aren't enabled.

Suggested-by: default avatarHélene Vulquin <oss@helene.moe>
Signed-off-by: default avatarDragan Simic <dsimic@manjaro.org>
Tested-by: default avatarHélène Vulquin <oss@helene.moe>
Link: https://patch.msgid.link/5b6bd142dab3ab93d7039db3e2fdcfea6bee2217.1727601608.git.dsimic@manjaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 36e69b16
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment