Commit e08dd85c authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

ANDROID: fix up abi issue with struct snd_pcm_runtime, again



A portion of the fix for CVE-2022-1048, commit 9017201e ("ALSA: pcm:
Fix potential AB/BA lock with buffer_mutex and mmap_lock") caused an ABI
break by adding a new field to struct snd_pcm_runtime.  Because we have
to keep this new addition, it is safe to move it to the end of the
structure because this is only ever created by the sound core, and
referenced as a pointer everywhere else.

This does require a .xml update also to handle the increased structure
size:

Leaf changes summary: 1 artifact changed
Changed leaf types summary: 1 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 0 Added function
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable

'struct snd_pcm_runtime at pcm.h:344:1' changed:
  type size changed from 6528 to 6592 (in bits)
  1 data member insertion:
    'atomic_t buffer_accessing', at offset 6528 (in bits) at pcm.h:433:1
  120 impacted interfaces

Bug: 161946584
Fixes: 9017201e ("ALSA: pcm: Fix potential AB/BA lock with buffer_mutex and mmap_lock")
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
Change-Id: I37b0eff7f0cbb5a9edad1f9b6b6cdcd1060bec9d
parent 8f4bd2a6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment