Commit df58e3ea authored by Carlos Llamas's avatar Carlos Llamas
Browse files

Revert "iommu: Get DT/ACPI parsing into the proper probe path"

This reverts commit bcb81ac6.

After pulling 'iommu-updates-v6.15' tag, there is a sporadic kernel
panic during boot while probing of the samsung_iommu driver:

  Unable to handle kernel NULL pointer dereference at virtual address 0000000000000099
  [...]
  Call trace:
   platform_dma_configure+0x44/0x8c (P)
   __iommu_probe_device+0x114/0x554
   probe_iommu_group+0x3c/0x68
   bus_for_each_dev+0x104/0x160
   iommu_device_register+0xe0/0x268
   samsung_sysmmu_device_probe+0x4c0/0x66c [samsung_iommu cf09c623f6d530040890d0a27bfefd6bbb9b9f2f]
   platform_probe+0xa0/0xe0
   really_probe+0x104/0x354
   __driver_probe_device+0xa0/0x130
   driver_probe_device+0x3c/0x220
   __driver_attach+0x118/0x1f8
   bus_for_each_dev+0x104/0x160
   driver_attach+0x24/0x34
   bus_add_driver+0x148/0x26c
   driver_register+0x68/0x104
   __platform_driver_register+0x20/0x30
   init_module+0x20/0xfe4 [samsung_iommu cf09c623f6d530040890d0a27bfefd6bbb9b9f2f]
   do_one_initcall+0x114/0x3e8
   do_init_module+0x58/0x1f0
   load_module+0x10e8/0x1250

This seems to be related to recent upstream changes from [1] for which
several similar issues have been reported, particularly against commit
bcb81ac6 ("iommu: Get DT/ACPI parsing into the proper probe path").

Reverting such commit fixes the panic, so let's temporarily remove it
while there is a permanent fix from either upstream or the samsung_iommu
driver.

Bug: 411464795
Cc: Tudor Ambarus <tudordana@google.com>
Cc: Will McVicker <willmcvicker@google.com>
Link: https://lore.kernel.org/all/cover.1740753261.git.robin.murphy@arm.com

 [1]
Change-Id: Ie8bb9379eaa7e4f113b7d8d884555bd80286600e
Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
parent cceec644
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment