io_uring: Clean up a false-positive warning from GCC 9.3.0
commit 0d7c1153 upstream. In io_recv(), if import_single_range() fails, the @flags variable is uninitialized, then it will goto out_free. After the goto, the compiler doesn't know that (ret < min_ret) is always true, so it thinks the "if ((flags & MSG_WAITALL) ..." path could be taken. The complaint comes from gcc-9 (Debian 9.3.0-22) 9.3.0: ``` fs/io_uring.c:5238 io_recvfrom() error: uninitialized symbol 'flags' ``` Fix this by bypassing the @ret and @flags check when import_single_range() fails. Reasons: 1. import_single_range() only returns -EFAULT when it fails. 2. At that point, @flags is uninitialized and shouldn't be read. Reported-by:kernel test robot <lkp@intel.com> Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Reported-by:
"Chen, Rong A" <rong.a.chen@intel.com> Link: https://lore.gnuweeb.org/timl/d33bb5a9-8173-f65b-f653-51fc0681c6d6@intel.com/ Cc: Pavel Begunkov <asml.silence@gmail.com> Suggested-by:
Ammar Faizi <ammarfaizi2@gnuweeb.org> Fixes: 7297ce3d ("io_uring: improve send/recv error handling") Signed-off-by:
Alviro Iskandar Setiawan <alviro.iskandar@gmail.com> Signed-off-by:
Ammar Faizi <ammarfaizi2@gnuweeb.org> Link: https://lore.kernel.org/r/20220207140533.565411-1-ammarfaizi2@gnuweeb.org Signed-off-by:
Jens Axboe <axboe@kernel.dk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Loading
-
mentioned in commit c4b25ae5
-
mentioned in commit 96e5989a
-
mentioned in commit 04207be4
-
mentioned in commit e1ff13a9
-
mentioned in commit 590e0ba8
-
mentioned in commit 838d8c84
-
mentioned in commit 5a1dfb3f
-
mentioned in commit 941adaf1
-
mentioned in commit 2decd07d
-
mentioned in commit 4faf0616
-
mentioned in commit fc978be7
-
mentioned in commit fb0cece7
-
mentioned in commit fb0cece7
-
mentioned in commit 6d8c59ce
-
mentioned in commit 035c1460
-
mentioned in commit 96885231
-
mentioned in commit 459fb187
-
mentioned in commit d75a605c
-
mentioned in commit b28a5779
-
mentioned in commit b28a5779
Please sign in to comment