Commit d0a2f462 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Praveen Talari
Browse files

UPSTREAM: serial: qcom_geni: Convert to platform remove callback returning void



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231110152927.70601-32-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Bug: 370629635
Bug: 375550406
Change-Id: I5d64129414dbd303ae50544ffa9385611dfabda7
(cherry picked from commit dd4d4497)
Signed-off-by: default avatarPraveen Talari <quic_ptalari@quicinc.com>
(cherry picked from commit 2c16ff38)
parent 57d765f0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment