io_uring/io-wq: fix `max_workers` breakage and `nr_workers` underflow
Commit 88e6c42e ("io_uring/io-wq: add check free worker before create new worker") reused the variable `do_create` for something else, abusing it for the free worker check. This caused the value to effectively always be `true` at the time `nr_workers < max_workers` was checked, but it should really be `false`. This means the `max_workers` setting was ignored, and worse: if the limit had already been reached, incrementing `nr_workers` was skipped even though another worker would be created. When later lots of workers exit, the `nr_workers` field could easily underflow, making the problem worse because more and more workers would be created without incrementing `nr_workers`. The simple solution is to use a different variable for the free worker check instead of using one variable for two different things. Cc: stable@vger.kernel.org Fixes: 88e6c42e ("io_uring/io-wq: add check free worker before create new worker") Signed-off-by:Max Kellermann <max.kellermann@ionos.com> Reviewed-by:
Fengnan Chang <changfengnan@bytedance.com> Signed-off-by:
Jens Axboe <axboe@kernel.dk>
Loading
Please sign in to comment