UPSTREAM: blk-mq: Don't disable preemption around __blk_mq_run_hw_queue().
__blk_mq_delay_run_hw_queue() disables preemption to get a stable current CPU number and then invokes __blk_mq_run_hw_queue() if the CPU number is part the mask. __blk_mq_run_hw_queue() acquires a spin_lock_t which is a sleeping lock on PREEMPT_RT and can't be acquired with disabled preemption. It is not required for correctness to invoke __blk_mq_run_hw_queue() on a CPU matching hctx->cpumask. Both (async and direct requests) can run on a CPU not matching hctx->cpumask. The CPU mask without disabling preemption and invoking __blk_mq_run_hw_queue(). Change-Id: Ia802417a96fdea68a3912a5ce59f2ea9b85cd664 Signed-off-by:Sebastian Andrzej Siewior <bigeasy@linutronix.de> Reviewed-by:
Ming Lei <ming.lei@redhat.com> Link: https://lore.kernel.org/r/YrLSEiNvagKJaDs5@linutronix.de Signed-off-by:
Jens Axboe <axboe@kernel.dk> (cherry picked from commit 3c8f9da4) [ bvanassche: Additionally, this patch fixes a sleep-in-atomic-context bug for drivers that set BLK_MQ_F_BLOCKING ] Signed-off-by:
Bart Van Assche <bvanassche@google.com>
Loading
Please sign in to comment