Commit c4f8e95a authored by Yangtao Li's avatar Yangtao Li Committed by Greg Kroah-Hartman
Browse files

mmc: davinci_mmc: Convert to platform remove callback returning void



[ Upstream commit bc1711e8 ]

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Link: https://lore.kernel.org/r/20230727070051.17778-7-frank.li@vivo.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Stable-dep-of: 55c421b3 ("mmc: davinci: Don't strip remove function when driver is builtin")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 8ea8ef5e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment