Commit c301d142 authored by Rohith Kollalsi's avatar Rohith Kollalsi Committed by Treehugger Robot
Browse files

FROMGIT: usb: dwc3: core: Do not perform GCTL_CORE_SOFTRESET during bootup



 According to the programming guide, it is recommended to
 perform a GCTL_CORE_SOFTRESET only when switching the mode
 from device to host or host to device. However, it is found
 that during bootup when __dwc3_set_mode() is called for the
 first time, GCTL_CORESOFTRESET is done with suspendable bit(BIT 17)
 of DWC3_GUSB3PIPECTL set. This some times leads to issues
 like controller going into bad state and controller registers
 reading value zero. Until GCTL_CORESOFTRESET is done and
 run/stop bit is set core initialization is not complete.
 Setting suspendable bit of DWC3_GUSB3PIPECTL and then
 performing GCTL_CORESOFTRESET is therefore not recommended.
 Avoid this by only performing the reset if current_dr_role is set,
 that is, when doing subsequent role switching.

 Fixes: f88359e1 ("usb: dwc3: core: Do core softreset when switch
 mode")
 Signed-off-by: default avatarRohith Kollalsi <quic_rkollals@quicinc.com>
 Link:
 https://lore.kernel.org/r/20220714045625.20377-1-quic_rkollals@quicinc.com


 Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>

 (cherry picked from commit 07903626
 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/


 usb-next)

BUG: 239121944
Change-Id: Ice6da5dd64896d5deeab425dd1ac5389425a1cc8
Signed-off-by: default avatarRohith Kollalsi <quic_rkollals@quicinc.com>
parent 8b19ed26
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment