Commit c0e55b3f authored by Dawid Niedzwiecki's avatar Dawid Niedzwiecki Committed by Hubert Mazur
Browse files

UPSTREAM: platform/chrome: cros_ec: jump to RW before probing



There are EC devices, like FPMCU, that use RWSIG as a method of
authenticating RW section. After the authentication succeeds, EC device
waits some time before jumping to RW. EC can be probed before the jump,
which means there is a time window after jump to RW in which EC won't
respond, because it is not initialized. It can cause a communication
errors after probing.

To avoid such problems, send the RWSIG continue command first, which
skips waiting for the jump to RW. Send the command more times, to make
sure EC is ready in RW before the start of the actual probing process. If
a EC device doesn't support the RWSIG, it will respond with invalid
command error code and probing will continue as usual.

Signed-off-by: default avatarDawid Niedzwiecki <dawidn@google.com>
Link: https://lore.kernel.org/r/20241206091514.2538350-2-dawidn@google.com


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
(cherry picked from commit 5ffa0dbf)

BUG=b:373543912
TEST=Make sure FPMCU is always registers for Omniknight devices.

Change-Id: I6dd5178f24169cc2f045ecfa6b13a1d8a5f2ea73
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/6218201


Reviewed-by: default avatarSean Paul <sean@poorly.run>
Reviewed-by: default avatarKornel Dulęba <korneld@google.com>
Reviewed-by: default avatarPatryk Duda <patrykd@google.com>
Tested-by: default avatarDawid Niedźwiecki <dawidn@google.com>
Commit-Queue: Dawid Niedźwiecki <dawidn@google.com>
Signed-off-by: default avatarHubert Mazur <hmazur@google.com>
parent 30feb143
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment