Commit bed931fd authored by SeongJae Park's avatar SeongJae Park Committed by Treehugger Robot
Browse files

UPSTREAM: mm/damon/sysfs: check error from damon_sysfs_update_target()

Patch series "mm/damon/sysfs: fix unhandled return values".

Some of DAMON sysfs interface code is not handling return values from some
functions.  As a result, confusing user input handling or NULL-dereference
is possible.  Check those properly.

This patch (of 3):

damon_sysfs_update_target() returns error code for failures, but its
caller, damon_sysfs_set_targets() is ignoring that.  The update function
seems making no critical change in case of such failures, but the behavior
will look like DAMON sysfs is silently ignoring or only partially
accepting the user input.  Fix it.

Link: https://lkml.kernel.org/r/20231106233408.51159-1-sj@kernel.org
Link: https://lkml.kernel.org/r/20231106233408.51159-2-sj@kernel.org


Fixes: 19467a95 ("mm/damon/sysfs: remove requested targets when online-commit inputs")
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>	[5.19+]
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>

(cherry picked from commit b4936b54)

Bug: 300502883
Bug: 319753692
Change-Id: I9bfea66f76ad094ed73defee5ff3fdb3794e8162
Signed-off-by: default avatarcui yangpei <cuiyangpei@xiaomi.com>
parent 3b86f469
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment