Commit bdb71ee6 authored by Zijun Hu's avatar Zijun Hu Committed by Greg Kroah-Hartman
Browse files

configfs: Do not override creating attribute file failure in populate_attrs()



commit f830edba upstream.

populate_attrs() may override failure for creating attribute files
by success for creating subsequent bin attribute files, and have
wrong return value.

Fix by creating bin attribute files under successfully creating
attribute files.

Fixes: 03607ace ("configfs: implement binary attributes")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJoel Becker <jlbec@evilplan.org>
Reviewed-by: default avatarBreno Leitao <leitao@debian.org>
Signed-off-by: default avatarZijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250507-fix_configfs-v3-2-fe2d96de8dc4@quicinc.com


Signed-off-by: default avatarAndreas Hindborg <a.hindborg@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 23fdf465
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment