FROMLIST: binder: fix UAF caused by offsets overwrite
Binder objects are processed and copied individually into the target buffer during transactions. Any raw data in-between these objects is copied as well. However, this raw data copy lacks an out-of-bounds check. If the raw data exceeds the data section size then the copy overwrites the offsets section. This eventually triggers an error that attempts to unwind the processed objects. However, at this point the offsets used to index these objects are now corrupted. Unwinding with corrupted offsets can result in decrements of arbitrary nodes and lead to their premature release. Other users of such nodes are left with a dangling pointer triggering a use-after-free. This issue is made evident by the following KASAN report (trimmed): ================================================================== BUG: KASAN: slab-use-after-free in _raw_spin_lock+0xe4/0x19c Write of size 4 at addr ffff47fc91598f04 by task binder-util/743 CPU: 9 UID: 0 PID: 743 Comm: binder-util Not tainted 6.11.0-rc4 #1 Hardware name: linux,dummy-virt (DT) Call trace: _raw_spin_lock+0xe4/0x19c binder_free_buf+0x128/0x434 binder_thread_write+0x8a4/0x3260 binder_ioctl+0x18f0/0x258c [...] Allocated by task 743: __kmalloc_cache_noprof+0x110/0x270 binder_new_node+0x50/0x700 binder_transaction+0x413c/0x6da8 binder_thread_write+0x978/0x3260 binder_ioctl+0x18f0/0x258c [...] Freed by task 745: kfree+0xbc/0x208 binder_thread_read+0x1c5c/0x37d4 binder_ioctl+0x16d8/0x258c [...] ================================================================== To avoid this issue, let's check that the raw data copy is within the boundaries of the data section. Fixes: 6d98eb95 ("binder: avoid potential data leakage when copying txn") Cc: Todd Kjos <tkjos@google.com> Cc: stable@vger.kernel.org Signed-off-by:Carlos Llamas <cmllamas@google.com> Bug: 352520660 Link: https://lore.kernel.org/all/20240822182353.2129600-1-cmllamas@google.com/ Change-Id: I1b2dd8403b63e5eeb58904558b7b542141c83fc2 Signed-off-by:
Carlos Llamas <cmllamas@google.com>
-
mentioned in commit c9f440c4
-
mentioned in commit ce351a8a
-
mentioned in commit 148d7d15
-
mentioned in commit c436466a
-
mentioned in commit d4c8c00e
-
mentioned in commit 9e5999d7
-
mentioned in commit 45f8a8cb
-
mentioned in commit 3b9c6855
-
mentioned in commit f8ade3f9
-
mentioned in commit b0edca1c
-
mentioned in commit 3ae7ccb3
-
mentioned in commit 47647b33
-
mentioned in commit 479205ed
-
mentioned in commit a4453dad
-
mentioned in commit b6e3779b
-
mentioned in commit c45eedd4
-
mentioned in commit 257f345c
-
mentioned in commit 25a1b1a8
-
mentioned in commit 38062c06
-
mentioned in commit 7529e2a0
-
mentioned in commit 5edbd6d9
-
mentioned in commit 4c18920c
-
mentioned in commit 4bb3978b
-
mentioned in commit 66085355
-
mentioned in commit 0f1047f9
-
mentioned in commit 0039d35a
-
mentioned in commit dffcd4e5
-
mentioned in commit 97810deb
-
mentioned in commit 8b56d1b0
-
mentioned in commit 4fab4d4c
-
mentioned in commit 2841c6b1
-
mentioned in commit b48fae82
-
mentioned in commit bf27eeed
-
mentioned in commit 9fa3ff87
-
mentioned in commit 44a9f39e
-
mentioned in commit 3240f22d
-
mentioned in commit 4faa5da0
-
mentioned in commit 89c29f54
-
mentioned in commit 41d4a8d9
-
mentioned in commit cb3a6414
-
mentioned in commit 000eb69e
-
mentioned in commit cc4c662a
-
mentioned in commit 368f0343
-
mentioned in commit 91168421
-
mentioned in commit ede78846
-
mentioned in commit daafaf1f
-
mentioned in commit b2c48aa4