arm64: fix oops in concurrently setting insn_emulation sysctls
emulation_proc_handler() changes table->data for proc_dointvec_minmax and can generate the following Oops if called concurrently with itself: | Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010 | Internal error: Oops: 96000006 [#1] SMP | Call trace: | update_insn_emulation_mode+0xc0/0x148 | emulation_proc_handler+0x64/0xb8 | proc_sys_call_handler+0x9c/0xf8 | proc_sys_write+0x18/0x20 | __vfs_write+0x20/0x48 | vfs_write+0xe4/0x1d0 | ksys_write+0x70/0xf8 | __arm64_sys_write+0x20/0x28 | el0_svc_common.constprop.0+0x7c/0x1c0 | el0_svc_handler+0x2c/0xa0 | el0_svc+0x8/0x200 To fix this issue, keep the table->data as &insn->current_mode and use container_of() to retrieve the insn pointer. Another mutex is used to protect against the current_mode update but not for retrieving insn_emulation as table->data is no longer changing. Co-developed-by:hewenliang <hewenliang4@huawei.com> Signed-off-by:
hewenliang <hewenliang4@huawei.com> Signed-off-by:
Haibin Zhang <haibinzhang@tencent.com> Reviewed-by:
Catalin Marinas <catalin.marinas@arm.com> Link: https://lore.kernel.org/r/20220128090324.2727688-1-hewenliang4@huawei.com Link: https://lore.kernel.org/r/9A004C03-250B-46C5-BF39-782D7551B00E@tencent.com Signed-off-by:
Will Deacon <will@kernel.org>
Loading
-
mentioned in commit e10bd267
-
mentioned in commit 0188c903
-
mentioned in commit 885349f5
-
mentioned in commit 77790139
-
mentioned in commit a44cd34b
-
mentioned in commit 076a395d
-
mentioned in commit 2cba0be7
-
mentioned in commit a20ff60c
-
mentioned in commit e55695bf
-
mentioned in commit edb17d76
-
mentioned in commit 69899fa4
-
mentioned in commit 390a6004
-
mentioned in commit b38f4656
-
mentioned in commit c09f7cfd
-
mentioned in commit 4d002f52
-
mentioned in commit 14d2789f
-
mentioned in commit bb1540be
-
mentioned in commit a85f3f5a
-
mentioned in commit 39793952
-
mentioned in commit ff7983aa
Please sign in to comment