Commit a8a1d010 authored by Theodore Ts'o's avatar Theodore Ts'o Committed by Ben Hutchings
Browse files

ext4: fix block validity checks for journal inodes using indirect blocks



commit 170417c8 upstream.

Commit 345c0dbf ("ext4: protect journal inode's blocks using
block_validity") failed to add an exception for the journal inode in
ext4_check_blockref(), which is the function used by ext4_get_branch()
for indirect blocks.  This caused attempts to read from the ext3-style
journals to fail with:

[  848.968550] EXT4-fs error (device sdb7): ext4_get_branch:171: inode #8: block 30343695: comm jbd2/sdb7-8: invalid block

Fix this by adding the missing exception check.

Fixes: 345c0dbf ("ext4: protect journal inode's blocks using block_validity")
Reported-by: default avatarArthur Marsh <arthur.marsh@internode.on.net>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
[bwh: Backported to 3.16: Use EXT4_HAS_COMPAT_FEATURE]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 310dac05
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment