udp: fix busy polling
Generic sk_busy_loop_end() only looks at sk->sk_receive_queue
for presence of packets.
Problem is that for UDP sockets after blamed commit, some packets
could be present in another queue: udp_sk(sk)->reader_queue
In some cases, a busy poller could spin until timeout expiration,
even if some packets are available in udp_sk(sk)->reader_queue.
v3: - make sk_busy_loop_end() nicer (Willem)
v2: - add a READ_ONCE(sk->sk_family) in sk_is_inet() to avoid KCSAN splats.
- add a sk_is_inet() check in sk_is_udp() (Willem feedback)
- add a sk_is_inet() check in sk_is_tcp().
Fixes: 2276f58a ("udp: use a separate rx queue for packet reception")
Signed-off-by:
Eric Dumazet <edumazet@google.com>
Reviewed-by:
Paolo Abeni <pabeni@redhat.com>
Reviewed-by:
Willem de Bruijn <willemb@google.com>
Reviewed-by:
Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by:
David S. Miller <davem@davemloft.net>
Loading
Please sign in to comment