UPSTREAM: sysrq: Use panic() to force a crash
(Upstream commit 8341f2f2.) sysrq_handle_crash() currently forces a crash by dereferencing a NULL pointer, which is undefined behavior in C. Just call panic() instead, which is simpler and doesn't depend on compiler specific handling of the undefined behavior. Remove the comment on why the RCU lock needs to be released, it isn't accurate anymore since the crash now isn't handled by the page fault handler (for reference: the comment was added by commit 984cf355 ("sysrq: Fix warning in sysrq generated crash.")). Releasing the lock is still good practice though. Suggested-by:Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Matthias Kaehlcke <mka@chromium.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Bug: 154769329 Change-Id: I04d57e4d84f59b04454fb77f4f62e9d9d6eee10d Signed-off-by:
Andrey Konovalov <andreyknvl@google.com>
Loading
Please sign in to comment