Revert "readahead: properly shorten readahead when falling back to do_page_cache_ra()"
This reverts commit 7c877586. Anders and Philippe have reported that recent kernels occasionally hang when used with NFS in readahead code. The problem has been bisected to 7c877586 ("readahead: properly shorten readahead when falling back to do_page_cache_ra()"). The cause of the problem is that ra->size can be shrunk by read_pages() call and subsequently we end up calling do_page_cache_ra() with negative (read huge positive) number of pages. Let's revert 7c877586 for now until we can find a proper way how the logic in read_pages() and page_cache_ra_order() can coexist. This can lead to reduced readahead throughput due to readahead window confusion but that's better than outright hangs. Link: https://lkml.kernel.org/r/20241126145208.985-1-jack@suse.cz Fixes: 7c877586 ("readahead: properly shorten readahead when falling back to do_page_cache_ra()") Reported-by:Anders Blomdell <anders.blomdell@gmail.com> Reported-by:
Philippe Troin <phil@fifi.org> Signed-off-by:
Jan Kara <jack@suse.cz> Tested-by:
Philippe Troin <phil@fifi.org> Cc: Matthew Wilcox <willy@infradead.org> Cc: <stable@vger.kernel.org> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org>
Loading
Please sign in to comment