FROMLIST: drm/msm: Allocate memory for disp snapshot with kvzalloc()
With the "drm/msm: add a display mmu fault handler" series [1] we saw issues in the field where memory allocation was failing when allocating space for registers in msm_disp_state_dump_regs(). Specifically we were seeing an order 5 allocation fail. It's not surprising that order 5 allocations will sometimes fail after the system has been up and running for a while. There's no need here for contiguous memory. Change the allocation to kvzalloc() which should make it much less likely to fail. [1] https://lore.kernel.org/r/20240628214848.4075651-1-quic_abhinavk@quicinc.com/ Fixes: 98659487 ("drm/msm: add support to take dpu snapshot") Signed-off-by:Douglas Anderson <dianders@chromium.org> Reviewed-by:
Abhinav Kumar <quic_abhinavk@quicinc.com> (am from https://patchwork.kernel.org/patch/13835319/) (also found at https://lore.kernel.org/r/20241014093605.2.I72441365ffe91f3dceb17db0a8ec976af8139590@changeid) UPSTREAM-TASK=b:374146921 BUG=b:372769248, b:372926092 TEST=With test patch force force a dpu core dump and see it collected Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/5941459 Commit-Queue: Douglas Anderson <dianders@chromium.org> Tested-by:
Douglas Anderson <dianders@chromium.org> Reviewed-by:
Sean Paul <sean@poorly.run> Reviewed-by:
Rob Clark <robdclark@chromium.org> Change-Id: I91c935b4c296030365ba480cc311496892feb859 Signed-off-by:
Hubert Mazur <hmazur@google.com> Signed-off-by:
Tomasz Nowicki <tnowicki@google.com>
Loading
Please sign in to comment