UPSTREAM: libceph: harden msgr2.1 frame segment length checks
commit a282a2f1 upstream. ceph_frame_desc::fd_lens is an int array. decode_preamble() thus effectively casts u32 -> int but the checks for segment lengths are written as if on unsigned values. While reading in HELLO or one of the AUTH frames (before authentication is completed), arithmetic in head_onwire_len() can get duped by negative ctrl_len and produce head_len which is less than CEPH_PREAMBLE_LEN but still positive. This would lead to a buffer overrun in prepare_read_control() as the preamble gets copied to the newly allocated buffer of size head_len. Bug: 303173400 Cc: stable@vger.kernel.org Fixes: cd1a677c ("libceph, ceph: implement msgr2.1 protocol (crc and secure modes)") Reported-by:Thelford Williams <thelford@google.com> Signed-off-by:
Ilya Dryomov <idryomov@gmail.com> Reviewed-by:
Xiubo Li <xiubli@redhat.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit db8ca8d9) Signed-off-by:
Lee Jones <joneslee@google.com> Change-Id: I49eacd72317664d920b13e3fec087d0e14802b93
Loading
Please sign in to comment