Commit 93ab4881 authored by Yeounsu Moon's avatar Yeounsu Moon Committed by Jakub Kicinski
Browse files

net: natsemi: fix `rx_dropped` double accounting on `netif_rx()` failure



`netif_rx()` already increments `rx_dropped` core stat when it fails.
The driver was also updating `ndev->stats.rx_dropped` in the same path.
Since both are reported together via `ip -s -s` command, this resulted
in drops being counted twice in user-visible stats.

Keep the driver update on `if (unlikely(!skb))`, but skip it after
`netif_rx()` errors.

Fixes: caf586e5 ("net: add a core netdev->rx_dropped counter")
Signed-off-by: default avatarYeounsu Moon <yyyynoom@gmail.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250913060135.35282-3-yyyynoom@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 97499e28
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment