Commit 9311d6d1 authored by Simon Horman's avatar Simon Horman Committed by Greg Kroah-Hartman
Browse files

pldmfw: Select CRC32 when PLDMFW is selected



[ Upstream commit 1224b218 ]

pldmfw calls crc32 code and depends on it being enabled, else
there is a link error as follows. So PLDMFW should select CRC32.

  lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
  pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'

This problem was introduced by commit b8265621 ("Add pldmfw library
for PLDM firmware update").

It manifests as of commit d69ea414 ("ice: implement device flash
update via devlink").

And is more likely to occur as of commit 9ad19171 ("lib/crc: remove
unnecessary prompt for CONFIG_CRC32 and drop 'default y'").

Found by chance while exercising builds based on tinyconfig.

Fixes: b8265621 ("Add pldmfw library for PLDM firmware update")
Signed-off-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250613-pldmfw-crc32-v1-1-f3fad109eee6@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4c8f5b04
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment