Commit 89ff5a15 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

BACKPORT: firmware: qcom_scm: Make __qcom_scm_is_call_available() return bool



Make __qcom_scm_is_call_available() return bool instead of int. The
function has "is" in the name, so it should return a bool to indicate
the truth of the call being available. Unfortunately, it can return a
number < 0 which also looks "true", but not all callers expect that and
thus they think a call is available when really the check to see if the
call is available failed to figure it out.

Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Cc: Elliot Berman <eberman@codeaurora.org>
Cc: Brian Masney <masneyb@onstation.org>
Cc: Stephan Gerhold <stephan@gerhold.net>
Cc: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: Douglas Anderson <dianders@chromium.org>
Fixes: 0f206514 ("scsi: firmware: qcom_scm: Add support for programming inline crypto keys")
Fixes: 0434a406 ("firmware: qcom: scm: add support to restore secure config to qcm_scm-32")
Fixes: b0a1614f ("firmware: qcom: scm: add OCMEM lock/unlock interface")
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20210223214539.1336155-2-swboyd@chromium.org


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
(cherry picked from commit 9d11af8b)
[__qcom_scm_is_call_available() is implemented in qcom_scm-{32,64}.c
on this branch, so make equivalent changes in both places]
Bug: 187129171
Signed-off-by: default avatarConnor O'Brien <connoro@google.com>
Change-Id: I7f3025ad5947691cbc74a92df5d8d65b419d2635
parent f93cecf6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment