Commit 89ff1bc0 authored by Will Deacon's avatar Will Deacon Committed by Isaac Manjarres
Browse files

FROMGIT: vsock/virtio: Move length check to callers of virtio_vsock_skb_rx_put()



virtio_vsock_skb_rx_put() only calls skb_put() if the length in the
packet header is not zero even though skb_put() handles this case
gracefully.

Remove the functionally redundant check from virtio_vsock_skb_rx_put()
and, on the assumption that this is a worthwhile optimisation for
handling credit messages, augment the existing length checks in
virtio_transport_rx_work() to elide the call for zero-length payloads.
Since the callers all have the length, extend virtio_vsock_skb_rx_put()
to take it as an additional parameter rather than fish it back out of
the packet header.

Note that the vhost code already has similar logic in
vhost_vsock_alloc_skb().

Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Signed-off-by: default avatarWill Deacon <will@kernel.org>
Message-Id: <20250717090116.11987-4-will@kernel.org>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
(cherry picked from commit e4b13dce25b41c63716ca51cbc33428245410592
 git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git

 vhost)
Bug: 421244320
Signed-off-by: default avatarWill Deacon <willdeacon@google.com>
Change-Id: I60ce676b0739ac7bcf8494dec9cb4672dd7b0159
parent 8632e465
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment