blk-mq: fix elevator depth_updated method
Current depth_updated has some problems: 1) depth_updated() will be called for each hctx, while all elevators will update async_depth for the disk level, this is not related to hctx; 2) In blk_mq_update_nr_requests(), if previous hctx update succeed and this hctx update failed, q->nr_requests will not be updated, while async_depth is already updated with new nr_reqeuests in previous depth_updated(); 3) All elevators are using q->nr_requests to calculate async_depth now, however, q->nr_requests is still the old value when depth_updated() is called from blk_mq_update_nr_requests(); Those problems are first from error path, then mq-deadline, and recently for bfq and kyber, fix those problems by: - pass in request_queue instead of hctx; - move depth_updated() after q->nr_requests is updated in blk_mq_update_nr_requests(); - add depth_updated() call inside init_sched() method to initialize async_depth; - remove init_hctx() method for mq-deadline and bfq that is useless now; Fixes: 77f1e0a5 ("bfq: update internal depth state when queue depth changes") Fixes: 39823b47 ("block/mq-deadline: Fix the tag reservation code") Fixes: 42e6c6ce ("lib/sbitmap: convert shallow_depth from one word to the whole sbitmap") Signed-off-by:Yu Kuai <yukuai3@huawei.com> Reviewed-by:
Hannes Reinecke <hare@suse.de> Reviewed-by:
Li Nan <linan122@huawei.com> Reviewed-by:
Nilay Shroff <nilay@linux.ibm.com> Link: https://lore.kernel.org/r/20250821060612.1729939-2-yukuai1@huaweicloud.com Signed-off-by:
Jens Axboe <axboe@kernel.dk>
Loading
Please sign in to comment