ANDROID: binder: change down_write to down_read
binder_update_page_range needs down_write of mmap_sem because vm_insert_page need to change vma->vm_flags to VM_MIXEDMAP unless it is set. However, when I profile binder working, it seems every binder buffers should be mapped in advance by binder_mmap. It means we could set VM_MIXEDMAP in binder_mmap time which is already hold a mmap_sem as down_write so binder_update_page_range doesn't need to hold a mmap_sem as down_write. Please use proper API down_read. It would help mmap_sem contention problem as well as fixing down_write abuse. Ganesh Mahendran tested app launching and binder throughput test and he said he couldn't find any problem and I did binder latency test per Greg KH request(Thanks Martijn to teach me how I can do) I cannot find any problem, too. Cc: Ganesh Mahendran <opensource.ganesh@gmail.com> Cc: Joe Perches <joe@perches.com> Cc: Arve Hjønnevåg <arve@android.com> Cc: Todd Kjos <tkjos@google.com> Reviewed-by:Martijn Coenen <maco@android.com> Signed-off-by:
Minchan Kim <minchan@kernel.org> Reviewed-by:
Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Loading
-
mentioned in commit be16a492
-
mentioned in commit 3c65adfb
-
mentioned in commit ea5be938
-
mentioned in commit 864095d6
-
mentioned in commit e3fc07b3
-
mentioned in commit bb398422
-
mentioned in commit cbe09517
-
mentioned in commit dc30d33a
-
mentioned in commit b684150a
-
mentioned in commit 0270aeeb
-
mentioned in commit dc467787
-
mentioned in commit 2fd357bf
-
mentioned in commit 0dcd69ac
-
mentioned in commit 673a27d5
-
mentioned in commit 1b6575b6
-
mentioned in commit accd5f17
-
mentioned in commit 18dcade5
-
mentioned in commit ff1b18f1
-
mentioned in commit d458eff2
-
mentioned in commit 15ec5032
-
mentioned in commit bbf70e00
-
mentioned in commit fa37bc68
-
mentioned in commit d7bc9ab3
-
mentioned in commit 1ca75597
-
mentioned in commit 557d712d
-
mentioned in commit dfc879c5
Please sign in to comment