Commit 7076ae1c authored by Ashish Mhetre's avatar Ashish Mhetre Committed by Daniel Mentz
Browse files

BACKPORT: iommu: Fix race condition during default domain allocation



When two devices with same SID are getting probed concurrently through
iommu_probe_device(), the iommu_domain sometimes is getting allocated more
than once as call to iommu_alloc_default_domain() is not protected for
concurrency. Furthermore, it leads to each device holding a different
iommu_domain pointer, separate IOVA space and only one of the devices'
domain is used for translations from IOMMU. This causes accesses from other
device to fault or see incorrect translations.
Fix this by protecting iommu_alloc_default_domain() call with group->mutex
and let all devices with same SID share same iommu_domain.

Signed-off-by: default avatarAshish Mhetre <amhetre@nvidia.com>
Link: https://lore.kernel.org/r/1628570641-9127-2-git-send-email-amhetre@nvidia.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>

Bug: 295978834
Bug: 298116110
(cherry picked from commit 211ff31b)
Signed-off-by: default avatarDaniel Mentz <danielmentz@google.com>
(cherry picked from https://android-review.googlesource.com/q/commit:e72e8f8acf1ee56eabfd78098bd77aa25bdda8b0)
Merged-In: Ia539055bad7c25e68e3324325879537f742c81fb
Change-Id: Ia539055bad7c25e68e3324325879537f742c81fb
parent 4196d8b1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment