Commit 6db9d3a5 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

netdevsim: don't assume core pre-populates HDS params on GET



Syzbot reports:

  BUG: KMSAN: uninit-value in nsim_get_ringparam+0xa8/0xe0 drivers/net/netdevsim/ethtool.c:77
   nsim_get_ringparam+0xa8/0xe0 drivers/net/netdevsim/ethtool.c:77
   ethtool_set_ringparam+0x268/0x570 net/ethtool/ioctl.c:2072
   __dev_ethtool net/ethtool/ioctl.c:3209 [inline]
   dev_ethtool+0x126d/0x2a40 net/ethtool/ioctl.c:3398
   dev_ioctl+0xb0e/0x1280 net/core/dev_ioctl.c:759

This is the SET path, where we call GET to either check user request
against max values, or check if any of the settings will change.

The logic in netdevsim is trying to report the default (ENABLED)
if user has not requested any specific setting. The user setting
is recorded in dev->cfg, don't depend on kernel_ringparam being
pre-populated with it.

Fixes: 928459bb ("net: ethtool: populate the default HDS params in the core")
Reported-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatar <syzbot+b3bcd80232d00091e061@syzkaller.appspotmail.com>
Tested-by: default avatar <syzbot+b3bcd80232d00091e061@syzkaller.appspotmail.com>
Link: https://patch.msgid.link/20250123221410.1067678-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3b1af766
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment