Commit 67ff14c5 authored by Sudeep Holla's avatar Sudeep Holla Committed by Andrei Homescu (xWF)
Browse files

UPSTREAM: firmware: arm_ffa: Explicitly cast return value from FFA_VERSION before comparison



The return value ver.a0 is unsigned long type and FFA_RET_NOT_SUPPORTED
is a negative value.

Since the return value from the firmware can be just 32-bit even on
64-bit systems as FFA specification mentions it as int32 error code in
w0 register, explicitly casting to s32 ensures correct sign interpretation
when comparing against a signed error code FFA_RET_NOT_SUPPORTED.

Without casting, comparison between unsigned long and a negative
constant could lead to unintended results due to type promotions.

Fixes: 3bbfe987 ("firmware: arm_ffa: Add initial Arm FFA driver support")
Reported-by: default avatarAndrei Homescu <ahomescu@google.com>
Message-Id: <20250221095633.506678-1-sudeep.holla@arm.com>
Change-Id: I383762ec971bce54f3d8aef564ebfca3b3ab2a0e
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
(cherry picked from commit cecf6a50)
Signed-off-by: default avatarAndrei Homescu <ahomescu@xwf.google.com>
Bug: 435501117
parent e5a17398
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment