Commit 62d9c62f authored by John Stultz's avatar John Stultz Committed by Dmitry Shmidt
Browse files

Revert "Input: evdev - Add ioctl to block suspend while event queue is not empty."



This reverts commit 78f63236.

I noticed the EVIOCSSUSPENDBLOCK input ioctl patch is still in
the tree. This is supposedly replaced by EPOLL_WAKEUP since v3.5
or so.

Looking at inputhub.h:

164         * The kernel evdev driver supports the EVIOCSSUSPENDBLOCK ioctl.
165         *
166         * When using this mechanism, the InputHub asks evdev to acquire and
167         * hold a wake lock whenever its buffer is non-empty. We
must take care
168         * to acquire our own userspace wake lock before draining
the buffer to
169         * prevent actually going back into suspend before we have fully
170         * processed all of the events.
171         *
172         * This mechanism only exists in older Android Linux kernels.
173         */
174        LEGACY_EVDEV_SUSPENDBLOCK_IOCTL,

And EventHub.cpp looks like its been properly converted to use EPOLL_WAKEUP.

So its probalby time to drop EVIOCSSUSPENDBLOCK from the kernel.

Change-Id: I2a18282e24f723a436799374a9527d5bdaec17ea
Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
parent 64775d15
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment