tls: fix handling of zero-length records on the rx_list
Each recvmsg() call must process either - only contiguous DATA records (any number of them) - one non-DATA record If the next record has different type than what has already been processed we break out of the main processing loop. If the record has already been decrypted (which may be the case for TLS 1.3 where we don't know type until decryption) we queue the pending record to the rx_list. Next recvmsg() will pick it up from there. Queuing the skb to rx_list after zero-copy decrypt is not possible, since in that case we decrypted directly to the user space buffer, and we don't have an skb to queue (darg.skb points to the ciphertext skb for access to metadata like length). Only data records are allowed zero-copy, and we break the processing loop after each non-data record. So we should never zero-copy and then find out that the record type has changed. The corner case we missed is when the initial record comes from rx_list, and it's zero length. Reported-by:Muhammad Alifa Ramdhan <ramdhan@starlabs.sg> Reported-by:
Billy Jheng Bing-Jhong <billy@starlabs.sg> Fixes: 84c61fe1 ("tls: rx: do not use the standard strparser") Reviewed-by:
Sabrina Dubroca <sd@queasysnail.net> Link: https://patch.msgid.link/20250820021952.143068-1-kuba@kernel.org Signed-off-by:
Jakub Kicinski <kuba@kernel.org>
-
mentioned in commit cb1598d6
-
mentioned in commit 344d1515
-
mentioned in commit a5c13965
-
mentioned in commit 2660c86a
-
mentioned in commit d7a6c595
-
mentioned in commit 4842b5f7
-
mentioned in commit c3100f2d
-
mentioned in commit 69f45551
-
mentioned in commit 5ac7aa16
-
mentioned in commit 1ab23524
-
mentioned in commit 016bf986
-
mentioned in commit 6ec5c9a7
-
mentioned in commit d0db7075
-
mentioned in commit 6ac76182
-
mentioned in commit af4db90a
-
mentioned in commit bce877df
-
mentioned in commit 96e5b3c1
-
mentioned in commit 0e782661
-
mentioned in commit ce34ab90
-
mentioned in commit 5e9c3706
-
mentioned in commit bf34b848
-
mentioned in commit 29906e3e
-
mentioned in commit 8e3822cd
-
mentioned in commit c25b7d8c
-
mentioned in commit b0cb0fd8
-
mentioned in commit bed84fe3
-
mentioned in commit 74715c47
-
mentioned in commit 7aff5c00
-
mentioned in commit 61a50bd2
-
mentioned in commit 730fdc75
-
mentioned in commit 7b2f38b8