FROMGIT: erofs: fix double free of 'copied'
Dan reported a new smatch warning [1] "fs/erofs/inode.c:210 erofs_read_inode() error: double free of 'copied'" Due to new chunk-based format handling logic, the error path can be called after kfree(copied). Set "copied = NULL" after kfree(copied) to fix this. [1] https://lore.kernel.org/r/202108251030.bELQozR7-lkp@intel.com Link: https://lore.kernel.org/r/20210825120757.11034-1-hsiangkao@linux.alibaba.com Fixes: c5aa903a ("erofs: support reading chunk-based uncompressed files") Reported-by:kernel test robot <lkp@intel.com> Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by:
Chao Yu <chao@kernel.org> Signed-off-by:
Gao Xiang <hsiangkao@linux.alibaba.com> (cherry picked from commit f60c7302 https://android.googlesource.com/kernel/common android13-5.10) BUG=b:273658215 TEST=`tast run $DUT arc.Boot.vm` TEST=`tast run $DUT arc.Playstore.vm` Change-Id: Ifcbe68431b5485f39bef4182b2823c53eb22c24b Signed-off-by:
Ryuichiro Chiba <chibar@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/4583880 Reviewed-by:
Sean Paul <sean@poorly.run> Reviewed-by:
Hikaru Nishida <hikalium@chromium.org>
Loading
Please sign in to comment