Commit 571591d5 authored by Waiman Long's avatar Waiman Long Committed by Carlos Llamas
Browse files

UPSTREAM: cgroup/rstat: Optimize cgroup_rstat_updated_list()



The current design of cgroup_rstat_cpu_pop_updated() is to traverse
the updated tree in a way to pop out the leaf nodes first before
their parents. This can cause traversal of multiple nodes before a
leaf node can be found and popped out. IOW, a given node in the tree
can be visited multiple times before the whole operation is done. So
it is not very efficient and the code can be hard to read.

With the introduction of cgroup_rstat_updated_list() to build a list
of cgroups to be flushed first before any flushing operation is being
done, we can optimize the way the updated tree nodes are being popped
by pushing the parents first to the tail end of the list before their
children. In this way, most updated tree nodes will be visited only
once with the exception of the subtree root as we still need to go
back to its parent and popped it out of its updated_children list.
This also makes the code easier to read.

Change-Id: I715b77540e3703a844674507accb0ba3b5d0af90
Signed-off-by: default avatarWaiman Long <longman@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
(cherry picked from commit d499fd41)
Bug: 322544714
Signed-off-by: default avatarT.J. Mercier <tjmercier@google.com>
parent b4958d2b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment