Commit 55ddb6c5 authored by Andrew Halaney's avatar Andrew Halaney Committed by David S. Miller
Browse files

net: stmmac: drop the ethtool begin() callback



This callback doesn't seem to serve much purpose, and prevents things
like:

    - systemd.link files from disabling autonegotiation
    - carrier detection in NetworkManager
    - any ethtool setting

prior to userspace bringing the link up.

The only fear I can think of is accessing unclocked resources due to
pm_runtime, but ethtool ioctls handle that as of commit
f32a2137 ("ethtool: runtime-resume netdev parent before ethtool ioctl ops")

Reviewed-by: default avatarDmitry Dolenko <d.dolenko@metrotek.ru>
Tested-by: default avatarDmitry Dolenko <d.dolenko@metrotek.ru>
Signed-off-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Reviewed-by: default avatarAlexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 221f9cce
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment