Commit 5554d4c2 authored by Adrian Salido's avatar Adrian Salido Committed by Mark Salyzyn
Browse files

UPSTREAM: dm ioctl: prevent stack leak in dm ioctl call



commit 4617f564 upstream.

When calling a dm ioctl that doesn't process any data
(IOCTL_FLAGS_NO_PARAMS), the contents of the data field in struct
dm_ioctl are left initialized.  Current code is incorrectly extending
the size of data copied back to user, causing the contents of kernel
stack to be leaked to user.  Fix by only copying contents before data
and allow the functions processing the ioctl to override.

Signed-off-by: default avatarAdrian Salido <salidoa@google.com>
Reviewed-by: default avatarAlasdair G Kergon <agk@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Bug: 35644370
Change-Id: I4f9a857d0f851ed37eff2d7b0f04e92dc6cf3b56
parent d342691c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment